aboutsummaryrefslogtreecommitdiffstats
path: root/guides
diff options
context:
space:
mode:
authorMatthew Draper <matthew@trebex.net>2017-04-09 00:36:45 +0930
committerMatthew Draper <matthew@trebex.net>2017-04-09 00:55:13 +0930
commit24eb450d7599bab1f5863e0578a21c65ca42a915 (patch)
treef01fc55f932b4c006946463edd58e16d04ade735 /guides
parent668f8691f1017042e238497d1a5b7b8bf1c43819 (diff)
downloadrails-24eb450d7599bab1f5863e0578a21c65ca42a915.tar.gz
rails-24eb450d7599bab1f5863e0578a21c65ca42a915.tar.bz2
rails-24eb450d7599bab1f5863e0578a21c65ca42a915.zip
Drop the "Sanity Check" contributing step
Diffstat (limited to 'guides')
-rw-r--r--guides/source/contributing_to_ruby_on_rails.md10
1 files changed, 0 insertions, 10 deletions
diff --git a/guides/source/contributing_to_ruby_on_rails.md b/guides/source/contributing_to_ruby_on_rails.md
index 2e8228a698..39f4272b3c 100644
--- a/guides/source/contributing_to_ruby_on_rails.md
+++ b/guides/source/contributing_to_ruby_on_rails.md
@@ -406,16 +406,6 @@ examples or multiple paragraphs. Otherwise, it's best to make a new paragraph.
Some changes require the dependencies to be upgraded. In these cases make sure you run `bundle update` to get the right version of the dependency and commit the `Gemfile.lock` file within your changes.
-### Sanity Check
-
-You should not be the only person who looks at the code before you submit it.
-If you know someone else who uses Rails, try asking them if they'll check out
-your work. If you don't know anyone else using Rails, try hopping into the IRC
-room or posting about your idea to the rails-core mailing list. Doing this in
-private before you push a patch out publicly is the "smoke test" for a patch:
-if you can't convince one other developer of the beauty of your code, you’re
-unlikely to convince the core team either.
-
### Commit Your Changes
When you're happy with the code on your computer, you need to commit the changes to Git: