diff options
| author | Yves Senn <yves.senn@gmail.com> | 2013-10-30 02:08:03 -0700 |
|---|---|---|
| committer | Yves Senn <yves.senn@gmail.com> | 2013-10-30 02:08:03 -0700 |
| commit | a02193854f995e597d008b309e6948ee97ad2122 (patch) | |
| tree | eb945b75d50e45ae9145c60627640306c92bd3f3 /guides/source | |
| parent | 609bc40904638663f92ca44ad05e8c95f87aa16b (diff) | |
| parent | 178c4f74f9289fff1a14b69e995ca61fd6d0346c (diff) | |
| download | rails-a02193854f995e597d008b309e6948ee97ad2122.tar.gz rails-a02193854f995e597d008b309e6948ee97ad2122.tar.bz2 rails-a02193854f995e597d008b309e6948ee97ad2122.zip | |
Merge pull request #12687 from notalex/master
Update pull request instructions as per the new Github UI [ci skip]
Diffstat (limited to 'guides/source')
| -rw-r--r-- | guides/source/contributing_to_ruby_on_rails.md | 19 |
1 files changed, 12 insertions, 7 deletions
diff --git a/guides/source/contributing_to_ruby_on_rails.md b/guides/source/contributing_to_ruby_on_rails.md index b2b08c82c6..a6956eb009 100644 --- a/guides/source/contributing_to_ruby_on_rails.md +++ b/guides/source/contributing_to_ruby_on_rails.md @@ -430,13 +430,18 @@ $ git push origin branch_name ### Issue a Pull Request -Navigate to the Rails repository you just pushed to (e.g. https://github.com/your-user-name/rails) and press "Pull Request" in the upper right hand corner. - -Write your branch name in the branch field (this is filled with "master" by default) and press "Update Commit Range". - -Ensure the changesets you introduced are included in the "Commits" tab. Ensure that the "Files Changed" incorporate all of your changes. - -Fill in some details about your potential patch including a meaningful title. When finished, press "Send pull request". The Rails core team will be notified about your submission. +Navigate to the Rails repository you just pushed to (e.g. +https://github.com/your-user-name/rails) and click on "Pull Requests" seen in +the right panel. On the next page, press "New pull request" in the upper right +hand corner. + +Click on "Edit", if you need to change the branches being compared (it compares +"master" by default) and press "Click to create a pull request for this +comparison". + +Ensure the changesets you introduced are included. Fill in some details about +your potential patch including a meaningful title. When finished, press "Send +pull request". The Rails core team will be notified about your submission. ### Get some Feedback |