diff options
| author | Vijay Dev <vijaydev.cse@gmail.com> | 2012-06-14 22:51:29 +0530 |
|---|---|---|
| committer | Vijay Dev <vijaydev.cse@gmail.com> | 2012-06-14 22:51:29 +0530 |
| commit | 5795efa9d8c330853c9ce4507abc3d5b8baa65e1 (patch) | |
| tree | 30a310d01d611b4672560e45d9386ebc69ba99ba /guides/source | |
| parent | 0a83e89222e817f9b1fa041cc286a83461533c0c (diff) | |
| download | rails-5795efa9d8c330853c9ce4507abc3d5b8baa65e1.tar.gz rails-5795efa9d8c330853c9ce4507abc3d5b8baa65e1.tar.bz2 rails-5795efa9d8c330853c9ce4507abc3d5b8baa65e1.zip | |
move the info about cosmetic changes to a diff location [ci skip]
Diffstat (limited to 'guides/source')
| -rw-r--r-- | guides/source/contributing_to_ruby_on_rails.textile | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/guides/source/contributing_to_ruby_on_rails.textile b/guides/source/contributing_to_ruby_on_rails.textile index 6416b75185..8e14297235 100644 --- a/guides/source/contributing_to_ruby_on_rails.textile +++ b/guides/source/contributing_to_ruby_on_rails.textile @@ -317,6 +317,8 @@ Now get busy and add or edit code. You’re on your branch now, so you can write * Include tests that fail without your code, and pass with it. * Update the (surrounding) documentation, examples elsewhere, and the guides: whatever is affected by your contribution. +TIP: Changes that are cosmetic in nature and do not add anything substantial to the stability, functionality, or testability of Rails will generally not be accepted. + h4. Follow the Coding Conventions Rails follows a simple set of coding style conventions. @@ -338,10 +340,6 @@ You should not be the only person who looks at the code before you submit it. Yo You might want also to check out the "RailsBridge BugMash":http://wiki.railsbridge.org/projects/railsbridge/wiki/BugMash as a way to get involved in a group effort to improve Rails. This can help you get started and help you check your code when you're writing your first patches. -h4. Cosmetic Changes - -Changes that are cosmetic in nature and do not improve the stability, functionality, or testability of rails will generally not be accepted. - h4. Commit Your Changes When you're happy with the code on your computer, you need to commit the changes to git: |