diff options
| author | Sruli Rapps <srulirapps@gmail.com> | 2016-02-19 16:01:03 +0200 | 
|---|---|---|
| committer | Sruli Rapps <srulirapps@gmail.com> | 2016-02-19 16:15:45 +0200 | 
| commit | 1cfeab531454d5e82db0d1b26a3ad86e3a4a6e30 (patch) | |
| tree | 88aec0f80319988b9a0ad726493cfe67922407fb /guides/source | |
| parent | af572a69a75ef87f17b8d06bdc8a56f3a59d779a (diff) | |
| download | rails-1cfeab531454d5e82db0d1b26a3ad86e3a4a6e30.tar.gz rails-1cfeab531454d5e82db0d1b26a3ad86e3a4a6e30.tar.bz2 rails-1cfeab531454d5e82db0d1b26a3ad86e3a4a6e30.zip | |
Dependencies clean up
Cleans up four items I came across in ActiveSupport::Dependencies:
- DependenciesTest#
  test_dependency_which_raises_exception_isnt_added_to_loaded_set:
  Fixes current implementation which will pass no matter what since the
  filepath is never added to "loaded" or "history" without being
  expanded first.
- Remove DependenciesTest#test_unhook. Seems leftover from when
  alias_method_chain was used in Loadable and ModuleConstMissing.
  The test will always pass since Module never responds to those methods
- WatchStack#new_constants documentation: update self to @stack.
  Looks like self was leftover from when WatchStack inherited from Hash
- Remove ActiveSupport namespace from call to
  Dependencies.constant_watch_stack.watching? since the namespace is not
  needed, Dependencies is called two other times in the same method
  without it (even on the same line) and it brings the line to within
  80 characters
Diffstat (limited to 'guides/source')
0 files changed, 0 insertions, 0 deletions
