aboutsummaryrefslogtreecommitdiffstats
path: root/guides/source/contributing_to_ruby_on_rails.md
diff options
context:
space:
mode:
authorSteve Klabnik <steve@steveklabnik.com>2013-08-26 13:44:03 -0700
committerSteve Klabnik <steve@steveklabnik.com>2013-08-26 13:44:03 -0700
commit0085ecbe62e4a98968b6855f9b9c7f5de372e0c8 (patch)
tree8ce257e74510b168b3de615fca7d80b97b7d0812 /guides/source/contributing_to_ruby_on_rails.md
parentc9f834bdfbfa38091dbeff97682085df280ea802 (diff)
downloadrails-0085ecbe62e4a98968b6855f9b9c7f5de372e0c8.tar.gz
rails-0085ecbe62e4a98968b6855f9b9c7f5de372e0c8.tar.bz2
rails-0085ecbe62e4a98968b6855f9b9c7f5de372e0c8.zip
Soften wording about knowing other devs.
Many people don't, so point them to a place where they can meet some.
Diffstat (limited to 'guides/source/contributing_to_ruby_on_rails.md')
-rw-r--r--guides/source/contributing_to_ruby_on_rails.md8
1 files changed, 7 insertions, 1 deletions
diff --git a/guides/source/contributing_to_ruby_on_rails.md b/guides/source/contributing_to_ruby_on_rails.md
index fa3a5958f6..da3aecf18c 100644
--- a/guides/source/contributing_to_ruby_on_rails.md
+++ b/guides/source/contributing_to_ruby_on_rails.md
@@ -291,7 +291,13 @@ Your name can be added directly after the last word if you don't provide any cod
### Sanity Check
-You should not be the only person who looks at the code before you submit it. You know at least one other Rails developer, right? Show them what you're doing and ask for feedback. Doing this in private before you push a patch out publicly is the "smoke test" for a patch: if you can't convince one other developer of the beauty of your code, you're unlikely to convince the core team either.
+You should not be the only person who looks at the code before you submit it.
+If you know someone else who uses Rails, try asking them if they'll check out
+your work. If you don't know anyone else using Rails, try hopping into the IRC
+room or posting about your idea to the rails-core mailing list. Doing this in
+private before you push a patch out publicly is the “smoke test” for a patch:
+if you can’t convince one other developer of the beauty of your code, you’re
+unlikely to convince the core team either.
### Commit Your Changes