diff options
| author | Caleb Wright <caleb.wright@gmail.com> | 2012-11-25 23:46:11 -0500 |
|---|---|---|
| committer | Caleb Wright <caleb.wright@gmail.com> | 2012-11-25 23:46:11 -0500 |
| commit | d34fd9fd826fb658cb348eacf8b9edfce06f2b3d (patch) | |
| tree | 9bd635dfdb6ba92fa190de7c0a4762a3a4b67b1b /guides/source/active_record_validations_callbacks.md | |
| parent | 064ae350dc8764dd10f2274a4293780b0210339c (diff) | |
| download | rails-d34fd9fd826fb658cb348eacf8b9edfce06f2b3d.tar.gz rails-d34fd9fd826fb658cb348eacf8b9edfce06f2b3d.tar.bz2 rails-d34fd9fd826fb658cb348eacf8b9edfce06f2b3d.zip | |
Update guides/source/active_record_validations_callbacks.md
In the expiration_date_cannot_be_in_the_past validation method, use `expiration_date.present?` instead of the double negative `!expiration_date.blank?`. Also join the comparisons with `&&` instead of `and`, which could cause unintended consequences.
Diffstat (limited to 'guides/source/active_record_validations_callbacks.md')
| -rw-r--r-- | guides/source/active_record_validations_callbacks.md | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/guides/source/active_record_validations_callbacks.md b/guides/source/active_record_validations_callbacks.md index 0f4140b650..28f693a856 100644 --- a/guides/source/active_record_validations_callbacks.md +++ b/guides/source/active_record_validations_callbacks.md @@ -674,7 +674,7 @@ class Invoice < ActiveRecord::Base :discount_cannot_be_greater_than_total_value def expiration_date_cannot_be_in_the_past - if !expiration_date.blank? and expiration_date < Date.today + if expiration_date.present? && expiration_date < Date.today errors.add(:expiration_date, "can't be in the past") end end |