diff options
author | Carlos Antonio da Silva <carlosantoniodasilva@gmail.com> | 2012-06-22 00:27:00 -0300 |
---|---|---|
committer | Carlos Antonio da Silva <carlosantoniodasilva@gmail.com> | 2012-06-22 08:28:26 -0300 |
commit | 8b173f3bc5484a33ab985fd1a556f1f744e82cd7 (patch) | |
tree | 00a6671324120c4bc03205df93effcd8357b8ce6 /guides/source/active_record_querying.textile | |
parent | 965b779eb2877c47f3bf5fe945c8f24dd576c3cd (diff) | |
download | rails-8b173f3bc5484a33ab985fd1a556f1f744e82cd7.tar.gz rails-8b173f3bc5484a33ab985fd1a556f1f744e82cd7.tar.bz2 rails-8b173f3bc5484a33ab985fd1a556f1f744e82cd7.zip |
Fix serializable_hash with xml generation and default :except option
When generating xml with a custom implementation of serializable_hash,
if using the :except option, it was being overriden by the default AR
implementation that attempts to ignore the inheritance column from STI
automatically. So, if you have an implementation like this:
def serializable_hash(options={})
super({ except: %w(some_attr) }.merge!(options))
end
The :except option was correctly being used for :json generation, but
not for :xml, because the options hash already contained the :except
key with the inheritance column, thus overriding the customization.
This commit fixes this problem by removing the :except logic from the
xml serializer, that happened before calling serializable_hash. Since
serializable_hash also does the same check for inheritance column, this
logic was duplicated in both places, thus it's safe to remove it from
xml serializer (see ActiveRecord::Serialization#serializable_hash).
This is an attempt to solve issue #2498, that claims for a
"Single transformation API for both xml and json representations".
Diffstat (limited to 'guides/source/active_record_querying.textile')
0 files changed, 0 insertions, 0 deletions