aboutsummaryrefslogtreecommitdiffstats
path: root/guides/source/active_record_callbacks.md
diff options
context:
space:
mode:
authorNathan Wenneker <nathan@preferral.com>2016-09-03 13:24:36 -0600
committerNathan Wenneker <nathan@preferral.com>2016-09-03 13:48:07 -0600
commit37219bbb5afb82935c60d37889a84cc58cec12ae (patch)
tree0920822deb8168bf3263af30e05a56c997508e06 /guides/source/active_record_callbacks.md
parent77ab69a249fce0e7a5bb9c7569962d18460e5e97 (diff)
downloadrails-37219bbb5afb82935c60d37889a84cc58cec12ae.tar.gz
rails-37219bbb5afb82935c60d37889a84cc58cec12ae.tar.bz2
rails-37219bbb5afb82935c60d37889a84cc58cec12ae.zip
Update docs for change in transaction callback exceptions
07d3d40 changed how exceptions are handled in after_commit and after_destroy callbacks. This commit updates the 5.0 release notes and the ActiveRecord callback guide to reflect the new behavior. [ci skip]
Diffstat (limited to 'guides/source/active_record_callbacks.md')
-rw-r--r--guides/source/active_record_callbacks.md2
1 files changed, 1 insertions, 1 deletions
diff --git a/guides/source/active_record_callbacks.md b/guides/source/active_record_callbacks.md
index a7975c7772..2a1c960887 100644
--- a/guides/source/active_record_callbacks.md
+++ b/guides/source/active_record_callbacks.md
@@ -431,4 +431,4 @@ class PictureFile < ApplicationRecord
end
```
-WARNING. The `after_commit` and `after_rollback` callbacks are guaranteed to be called for all models created, updated, or destroyed within a transaction block. If any exceptions are raised within one of these callbacks, they will be ignored so that they don't interfere with the other callbacks. As such, if your callback code could raise an exception, you'll need to rescue it and handle it appropriately within the callback.
+WARNING. The `after_commit` and `after_rollback` callbacks are called for all models created, updated, or destroyed within a transaction block. However, if an exception is raised within one of these callbacks, the exception will bubble up and any remaining `after_commit` or `after_rollback` methods will _not_ be executed. As such, if your callback code could raise an exception, you'll need to rescue it and handle it within the callback in order to allow other callbacks to run.