diff options
| author | Xavier Noria <fxn@hashref.com> | 2014-09-04 00:18:39 +0200 |
|---|---|---|
| committer | Xavier Noria <fxn@hashref.com> | 2014-09-04 00:45:01 +0200 |
| commit | 4dfe140ef3fbed34e6ae8af3b32402630a4690a1 (patch) | |
| tree | 279954dc1f540a5b4c38502f0e5155902a6bd657 /ci | |
| parent | faa0f324345f48c9f41f02c626055a7fadf1ddf4 (diff) | |
| download | rails-4dfe140ef3fbed34e6ae8af3b32402630a4690a1.tar.gz rails-4dfe140ef3fbed34e6ae8af3b32402630a4690a1.tar.bz2 rails-4dfe140ef3fbed34e6ae8af3b32402630a4690a1.zip | |
code gardening in ActionController::Renderers
* Renames _handle_render_options to _render_to_body_with_renderer, which is more
intention-revealing.
* The name of the dynamically generated method for a renderer with key :js was
"_render_option_js".
That name is too weak. :js is an option if you see the render argument as just
a generic options hash, but in the context of renderers that's the renderer
key, is what identifies the renderer.
Now "_render_with_renderer_js" is generated instead, which is crystal clear.
* The name of the dynamically generated method for the renderer was constructed
using string literals in a few places. That is now encapsulated in a method.
* Since we were on it, also removed a couple of redundant selfs.
Diffstat (limited to 'ci')
0 files changed, 0 insertions, 0 deletions