aboutsummaryrefslogtreecommitdiffstats
path: root/ci/custom_cops/test/custom_cops/refute_not_test.rb
diff options
context:
space:
mode:
authorDaniel Colson <danieljamescolson@gmail.com>2018-04-17 08:37:35 -0400
committerDaniel Colson <danieljamescolson@gmail.com>2018-04-19 08:11:28 -0400
commit087e0ccb72e7a1491701dd1d1d49746f745d9d68 (patch)
treeda79375760e74db0bc466695cce13689666ef430 /ci/custom_cops/test/custom_cops/refute_not_test.rb
parentef2af628a9ec1cc4e7b6997a021dd3f85cfe4665 (diff)
downloadrails-087e0ccb72e7a1491701dd1d1d49746f745d9d68.tar.gz
rails-087e0ccb72e7a1491701dd1d1d49746f745d9d68.tar.bz2
rails-087e0ccb72e7a1491701dd1d1d49746f745d9d68.zip
Add RuboCop for `assert_not` over `assert !`
We added `assert_not` in f75addd "to replace warty 'assert !foo'". fa8d35b agrees that it is warty, and so do I. This custom Rubocop rule turns the wart into a violation. As with my last custom cop, https://github.com/rails/rails/pull/32441, I want to make sure this looks right on code climate before pushing another commit to autocorrect everything. @toshimaru I just noticed https://github.com/toshimaru/rubocop-rails/pull/26 Is there a better way to add these custom cops, or were you saying we shouldn't have custom cops at all?
Diffstat (limited to 'ci/custom_cops/test/custom_cops/refute_not_test.rb')
-rw-r--r--ci/custom_cops/test/custom_cops/refute_not_test.rb11
1 files changed, 1 insertions, 10 deletions
diff --git a/ci/custom_cops/test/custom_cops/refute_not_test.rb b/ci/custom_cops/test/custom_cops/refute_not_test.rb
index 5dbd8bf32a..f0f6eaeda0 100644
--- a/ci/custom_cops/test/custom_cops/refute_not_test.rb
+++ b/ci/custom_cops/test/custom_cops/refute_not_test.rb
@@ -1,7 +1,7 @@
# frozen_string_literal: true
require "support/cop_helper"
-require "./lib/custom_cops/refute_not"
+require_relative "../../lib/custom_cops/refute_not"
class RefuteNotTest < ActiveSupport::TestCase
include CopHelper
@@ -59,15 +59,6 @@ class RefuteNotTest < ActiveSupport::TestCase
private
- def assert_offense(cop, expected_message)
- assert_not_empty cop.offenses
-
- offense = cop.offenses.first
- carets = "^" * offense.column_length
-
- assert_equal expected_message, "#{carets} #{offense.message}"
- end
-
def offense_message(refute_method, assert_method)
carets = "^" * refute_method.to_s.length
"#{carets} Prefer `#{assert_method}` over `#{refute_method}`"