diff options
author | Koichi ITO <koic.ito@gmail.com> | 2018-07-03 12:11:28 +0900 |
---|---|---|
committer | Koichi ITO <koic.ito@gmail.com> | 2018-07-26 17:48:07 +0900 |
commit | 211b10aea6313582e2f837edd297af4aeb33c8dc (patch) | |
tree | 9e5b037b2d9ae2b65182d154fd7426bed3b14a20 /ci/custom_cops/lib/custom_cops/assert_not.rb | |
parent | 91fd679710118482f718ea710710561f1cfb0b70 (diff) | |
download | rails-211b10aea6313582e2f837edd297af4aeb33c8dc.tar.gz rails-211b10aea6313582e2f837edd297af4aeb33c8dc.tar.bz2 rails-211b10aea6313582e2f837edd297af4aeb33c8dc.zip |
Bump RuboCop to 0.58.2
## Summary
RuboCop 0.58.2 was released.
https://github.com/rubocop-hq/rubocop/releases/tag/v0.58.2
And rubocop-0-58 channel is available in Code Climate.
https://github.com/codeclimate/codeclimate/releases/tag/v0.76.0
https://github.com/codeclimate/codeclimate/commit/38f21f0
In addition, the following changes are made in this PR.
- Replace Custom cops with Rails cops
- Add jaro_winkler gem to Gemfile.lock
### Replace Custom cops with Rails cops
These are compatible replacements.
- Replace `CustomCops/AssertNot` cop with `Rails/AssertNot` cop.
- Replace `CustomCops/RefuteNot` cop with `Rails/RefuteMethods` cop.
With this replacement, it was decided to use cop of RuboCop itself.
It removes the code related to CustomCops accordingly.
### Add jaro_winkler gem to Gemfile.lock
Since RuboCop 0.57.0 depends on jaro_winkler gem,
it has been added to Gemfile.lock.
Diffstat (limited to 'ci/custom_cops/lib/custom_cops/assert_not.rb')
-rw-r--r-- | ci/custom_cops/lib/custom_cops/assert_not.rb | 40 |
1 files changed, 0 insertions, 40 deletions
diff --git a/ci/custom_cops/lib/custom_cops/assert_not.rb b/ci/custom_cops/lib/custom_cops/assert_not.rb deleted file mode 100644 index 8b49d3eac2..0000000000 --- a/ci/custom_cops/lib/custom_cops/assert_not.rb +++ /dev/null @@ -1,40 +0,0 @@ -# frozen_string_literal: true - -module CustomCops - # Enforces the use of `assert_not` over `assert !`. - # - # @example - # # bad - # assert !x - # assert ! x - # - # # good - # assert_not x - # - class AssertNot < RuboCop::Cop::Cop - MSG = "Prefer `assert_not` over `assert !`" - - def_node_matcher :offensive?, "(send nil? :assert (send ... :!) ...)" - - def on_send(node) - add_offense(node) if offensive?(node) - end - - def autocorrect(node) - expression = node.loc.expression - - ->(corrector) do - corrector.replace( - expression, - corrected_source(expression.source) - ) - end - end - - private - - def corrected_source(source) - source.gsub(/^assert(\(| ) *! */, "assert_not\\1") - end - end -end |