diff options
author | Xavier Noria <fxn@hashref.com> | 2010-05-03 22:04:47 +0200 |
---|---|---|
committer | Xavier Noria <fxn@hashref.com> | 2010-05-03 22:04:47 +0200 |
commit | 9e085a9f3365e316e2026addedef30f08ead46f2 (patch) | |
tree | 3b12c3bd2162f9e91eb3a5cce880ca726cdb1a73 /activesupport | |
parent | 34d57251672d31e70d3ce53e1df3ea9dd4aae9c8 (diff) | |
download | rails-9e085a9f3365e316e2026addedef30f08ead46f2.tar.gz rails-9e085a9f3365e316e2026addedef30f08ead46f2.tar.bz2 rails-9e085a9f3365e316e2026addedef30f08ead46f2.zip |
adds a comment explaining why BigDecimal#as_json returns a JSON string
Diffstat (limited to 'activesupport')
-rw-r--r-- | activesupport/lib/active_support/json/encoding.rb | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/activesupport/lib/active_support/json/encoding.rb b/activesupport/lib/active_support/json/encoding.rb index 3d7be8da1f..02c233595d 100644 --- a/activesupport/lib/active_support/json/encoding.rb +++ b/activesupport/lib/active_support/json/encoding.rb @@ -1,7 +1,7 @@ # encoding: utf-8 require 'bigdecimal' require 'active_support/core_ext/array/wrap' -require 'active_support/core_ext/big_decimal/conversions' +require 'active_support/core_ext/big_decimal/conversions' # for #to_s require 'active_support/core_ext/hash/except' require 'active_support/core_ext/hash/slice' require 'active_support/core_ext/module/delegation' @@ -179,6 +179,14 @@ class Numeric end class BigDecimal + # A BigDecimal would be naturally represented as a JSON number. Most libraries, + # however, parse non-integer JSON numbers directly as floats. Clients using + # those libraries would get in general a wrong number and no way to recover + # other than manually inspecting the string with the JSON code itself. + # + # That's why a JSON string is returned. The JSON literal is not numeric, but if + # the other end knows by contract that the data is supposed to be a BigDecimal, + # it still has the chance to post-process the string and get the real value. def as_json(options = nil) to_s end #:nodoc: end |