aboutsummaryrefslogtreecommitdiffstats
path: root/activesupport
diff options
context:
space:
mode:
authorGeoff Buesing <gbuesing@gmail.com>2008-02-10 17:02:22 +0000
committerGeoff Buesing <gbuesing@gmail.com>2008-02-10 17:02:22 +0000
commit94fa9fb74541b60ed04f2694558a6a98a9ce1cab (patch)
treeb615ef44b629aae80daef6a66ac5bb9b4e52e03d /activesupport
parent2c8fb682cb6dfe889b31bbb76c90de5011aec009 (diff)
downloadrails-94fa9fb74541b60ed04f2694558a6a98a9ce1cab.tar.gz
rails-94fa9fb74541b60ed04f2694558a6a98a9ce1cab.tar.bz2
rails-94fa9fb74541b60ed04f2694558a6a98a9ce1cab.zip
TimeZone#new renamed #local, so that new TimeWithZone instances can be created via Time.zone.local()
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8847 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
Diffstat (limited to 'activesupport')
-rw-r--r--activesupport/CHANGELOG2
-rw-r--r--activesupport/lib/active_support/values/time_zone.rb6
-rw-r--r--activesupport/test/time_zone_test.rb4
3 files changed, 7 insertions, 5 deletions
diff --git a/activesupport/CHANGELOG b/activesupport/CHANGELOG
index 38294ebef7..6b66875012 100644
--- a/activesupport/CHANGELOG
+++ b/activesupport/CHANGELOG
@@ -1,5 +1,7 @@
*SVN*
+* TimeZone#new method renamed #local; when used with Time.zone, constructor now reads: Time.zone.local() [Geoff Buesing]
+
* Added Base64.encode64s to encode values in base64 without the newlines. This makes the values immediately usable as URL parameters or memcache keys without further processing [DHH]
* Remove :nodoc: entries around the ActiveSupport test/unit assertions. #10946 [dancroak, jamesh]
diff --git a/activesupport/lib/active_support/values/time_zone.rb b/activesupport/lib/active_support/values/time_zone.rb
index fed64579e4..4f2fc5e44b 100644
--- a/activesupport/lib/active_support/values/time_zone.rb
+++ b/activesupport/lib/active_support/values/time_zone.rb
@@ -177,9 +177,9 @@ class TimeZone
# Method for creating new ActiveSupport::TimeWithZone instance in time zone of self. Example:
#
- # Time.zone = "Hawaii" # => "Hawaii"
- # Time.zone.new(2007, 2, 1, 15, 30, 45) # => Thu, 01 Feb 2007 15:30:45 HST -10:00
- def new(*args)
+ # Time.zone = "Hawaii" # => "Hawaii"
+ # Time.zone.local(2007, 2, 1, 15, 30, 45) # => Thu, 01 Feb 2007 15:30:45 HST -10:00
+ def local(*args)
Time.utc_time(*args).change_time_zone(self)
end
diff --git a/activesupport/test/time_zone_test.rb b/activesupport/test/time_zone_test.rb
index cd3972a41c..43f60690d9 100644
--- a/activesupport/test/time_zone_test.rb
+++ b/activesupport/test/time_zone_test.rb
@@ -129,8 +129,8 @@ class TimeZoneTest < Test::Unit::TestCase
assert !TimeZone.us_zones.include?(TimeZone["Kuala Lumpur"])
end
- def test_new
- time = TimeZone["Hawaii"].new(2007, 2, 5, 15, 30, 45)
+ def test_local
+ time = TimeZone["Hawaii"].local(2007, 2, 5, 15, 30, 45)
assert_equal Time.utc(2007, 2, 5, 15, 30, 45), time.time
assert_equal TimeZone["Hawaii"], time.time_zone
end