diff options
| author | Daniel Colson <danieljamescolson@gmail.com> | 2018-11-24 11:42:28 -0500 |
|---|---|---|
| committer | Daniel Colson <danieljamescolson@gmail.com> | 2018-11-24 11:42:28 -0500 |
| commit | 3cfb05daa4f1e76eaca0a79fc9df340af02ee3dc (patch) | |
| tree | 2be27400a4dcf216105eb9dc24d50fa178b7899b /activesupport | |
| parent | 171e32fc779fc26804f6670ea41850aec282d882 (diff) | |
| download | rails-3cfb05daa4f1e76eaca0a79fc9df340af02ee3dc.tar.gz rails-3cfb05daa4f1e76eaca0a79fc9df340af02ee3dc.tar.bz2 rails-3cfb05daa4f1e76eaca0a79fc9df340af02ee3dc.zip | |
Remove unnecessary reduce in Duration#inspect
When the `Duration` class was introduced in 276c9f29, the `parts` were
represented as an array of arrays
(for example `[[:seconds, 5], [:days, 3], [:seconds, 7]]`).
At that time the `reduce` in `#inspect` made sense,
since we would need to get the totals for each part
(the example would become `{ seconds: 12, days: 3 }`).
With the current version of `Duration` we call `to_h` on the `parts`
immediately on initialize, so now the `reduce` doesn't seem to be doing
anything meaningful.
Diffstat (limited to 'activesupport')
| -rw-r--r-- | activesupport/lib/active_support/duration.rb | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/activesupport/lib/active_support/duration.rb b/activesupport/lib/active_support/duration.rb index 88897f811e..314c926ac0 100644 --- a/activesupport/lib/active_support/duration.rb +++ b/activesupport/lib/active_support/duration.rb @@ -373,7 +373,6 @@ module ActiveSupport return "0 seconds" if parts.empty? parts. - reduce(::Hash.new(0)) { |h, (l, r)| h[l] += r; h }. sort_by { |unit, _ | PARTS.index(unit) }. map { |unit, val| "#{val} #{val == 1 ? unit.to_s.chop : unit.to_s}" }. to_sentence(locale: ::I18n.default_locale) |