Deprecate `HWIDA.new_from_hash_copying_default`

This method was already niche, and is now redundant with `.new`

2 files changed, 6 insertions, 1 deletions

diff --git a/activesupport/lib/active_support/hash_with_indifferent_access.rb b/activesupport/lib/active_support/hash_with_indifferent_access.rb
index 3edeeb0029..4ff35a45a1 100644
--- a/activesupport/lib/active_support/hash_with_indifferent_access.rb
+++ b/activesupport/lib/active_support/hash_with_indifferent_access.rb
@@ -77,6 +77,11 @@ module ActiveSupport
     end
 
     def self.new_from_hash_copying_default(hash)
+      ActiveSupport::Deprecation.warn(<<-MSG.squish)
+        `ActiveSupport::HashWithIndifferentAccess.new_from_hash_copying_default`
+        has been deprecated, and will be removed in Rails 5.1. The behavior of
+        this method is now identical to the behavior of `.new`.
+      MSG
       new(hash)
     end
 
diff --git a/activesupport/test/core_ext/hash_ext_test.rb b/activesupport/test/core_ext/hash_ext_test.rb
index 1d9b56b1b4..265416dce7 100644
--- a/activesupport/test/core_ext/hash_ext_test.rb
+++ b/activesupport/test/core_ext/hash_ext_test.rb
@@ -1042,7 +1042,7 @@ class HashExtTest < ActiveSupport::TestCase
     hash = Hash.new
     hash.default_proc = proc { |h, k| raise "walrus" }
 
-    assert_nothing_raised { HashWithIndifferentAccess.new_from_hash_copying_default(hash) }
+    assert_deprecated { HashWithIndifferentAccess.new_from_hash_copying_default(hash) }
   end
 
   def test_new_with_to_hash_conversion_copies_default