aboutsummaryrefslogtreecommitdiffstats
path: root/activesupport
diff options
context:
space:
mode:
authorBenjamin Fleischer <github@benjaminfleischer.com>2013-09-30 15:20:28 -0500
committerBenjamin Fleischer <github@benjaminfleischer.com>2013-09-30 19:57:03 -0500
commit0b0beb71d648efb417207502e142289ee77aa723 (patch)
tree948270a32a97ad2fe10d8b59145c9253c87635f1 /activesupport
parent432ffdb0739426122e216e0f7199ebc16f15de7e (diff)
downloadrails-0b0beb71d648efb417207502e142289ee77aa723.tar.gz
rails-0b0beb71d648efb417207502e142289ee77aa723.tar.bz2
rails-0b0beb71d648efb417207502e142289ee77aa723.zip
require_dependency should allow Pathname-like objects, not just String
Diffstat (limited to 'activesupport')
-rw-r--r--activesupport/lib/active_support/dependencies.rb4
-rw-r--r--activesupport/test/dependencies_test.rb11
2 files changed, 14 insertions, 1 deletions
diff --git a/activesupport/lib/active_support/dependencies.rb b/activesupport/lib/active_support/dependencies.rb
index fff4c776a9..565d933cb3 100644
--- a/activesupport/lib/active_support/dependencies.rb
+++ b/activesupport/lib/active_support/dependencies.rb
@@ -198,9 +198,11 @@ module ActiveSupport #:nodoc:
Dependencies.require_or_load(file_name)
end
+ # Files required this way can be reloaded in development mode
def require_dependency(file_name, message = "No such file to load -- %s")
+ file_name = file_name.to_path if file_name.respond_to?(:to_path)
unless file_name.is_a?(String)
- raise ArgumentError, "the file name must be a String -- you passed #{file_name.inspect}"
+ raise ArgumentError, "the file name must either be a String or implement #to_path -- you passed #{file_name.inspect}"
end
Dependencies.depend_on(file_name, message)
diff --git a/activesupport/test/dependencies_test.rb b/activesupport/test/dependencies_test.rb
index 4b1426bb2e..b8cbbca601 100644
--- a/activesupport/test/dependencies_test.rb
+++ b/activesupport/test/dependencies_test.rb
@@ -35,6 +35,17 @@ class DependenciesTest < ActiveSupport::TestCase
assert_equal expected.path, e.path
end
+ def test_require_dependency_accepts_an_object_which_implements_to_path
+ o = Object.new
+ def o.to_path; 'dependencies/service_one'; end
+ assert_nothing_raised {
+ require_dependency o
+ }
+ assert defined?(ServiceOne)
+ ensure
+ remove_constants(:ServiceOne)
+ end
+
def test_tracking_loaded_files
require_dependency 'dependencies/service_one'
require_dependency 'dependencies/service_two'