aboutsummaryrefslogtreecommitdiffstats
path: root/activesupport
diff options
context:
space:
mode:
authorJon Moss <me@jonathanmoss.me>2017-03-13 19:45:35 -0400
committerJon Moss <me@jonathanmoss.me>2017-03-13 19:45:35 -0400
commit0713efb509cffe8e76f92abd4c71b5c38a18ccdc (patch)
tree81d6050d4c1a548c39400bad31d2428b6ed6425a /activesupport
parent804f27baf7617b29272d9c24378bf71c64e35126 (diff)
downloadrails-0713efb509cffe8e76f92abd4c71b5c38a18ccdc.tar.gz
rails-0713efb509cffe8e76f92abd4c71b5c38a18ccdc.tar.bz2
rails-0713efb509cffe8e76f92abd4c71b5c38a18ccdc.zip
Lint activesupport/CHANGELOG.md
[ci skip]
Diffstat (limited to 'activesupport')
-rw-r--r--activesupport/CHANGELOG.md18
1 files changed, 10 insertions, 8 deletions
diff --git a/activesupport/CHANGELOG.md b/activesupport/CHANGELOG.md
index 2cee8375b7..de1418bb86 100644
--- a/activesupport/CHANGELOG.md
+++ b/activesupport/CHANGELOG.md
@@ -1,7 +1,7 @@
* Update `titleize` regex to allow apostrophes
In 4b685aa the regex in `titleize` was updated to not match apostrophes to
- better reflect the nature of the transformation. Unfortunately this had the
+ better reflect the nature of the transformation. Unfortunately, this had the
side effect of breaking capitalization on the first word of a sub-string, e.g:
>> "This was 'fake news'".titleize
@@ -22,7 +22,7 @@
* Add `Time.rfc3339` parsing method
- The `Time.xmlschema` and consequently its alias `iso8601` accepts timestamps
+ `Time.xmlschema` and consequently its alias `iso8601` accepts timestamps
without a offset in contravention of the RFC 3339 standard. This method
enforces that constraint and raises an `ArgumentError` if it doesn't.
@@ -30,7 +30,7 @@
* Add `ActiveSupport::TimeZone.rfc3339` parsing method
- Previously there was no way to get a RFC 3339 timestamp into a specific
+ Previously, there was no way to get a RFC 3339 timestamp into a specific
timezone without either using `parse` or chaining methods. The new method
allows parsing directly into the timezone, e.g:
@@ -39,7 +39,7 @@
>> Time.zone.rfc3339("1999-12-31T14:00:00Z")
=> Fri, 31 Dec 1999 14:00:00 HST -10:00
- This new method has stricter semantics than the current `parse` method
+ This new method has stricter semantics than the current `parse` method,
and will raise an `ArgumentError` instead of returning nil, e.g:
>> Time.zone = "Hawaii"
@@ -63,7 +63,7 @@
* Add `ActiveSupport::TimeZone.iso8601` parsing method
- Previously there was no way to get a ISO 8601 timestamp into a specific
+ Previously, there was no way to get a ISO 8601 timestamp into a specific
timezone without either using `parse` or chaining methods. The new method
allows parsing directly into the timezone, e.g:
@@ -72,7 +72,7 @@
>> Time.zone.iso8601("1999-12-31T14:00:00Z")
=> Fri, 31 Dec 1999 14:00:00 HST -10:00
- If the timestamp is a ISO 8601 date (YYYY-MM-DD) then the time is set
+ If the timestamp is a ISO 8601 date (YYYY-MM-DD), then the time is set
to midnight, e.g:
>> Time.zone = "Hawaii"
@@ -80,7 +80,7 @@
>> Time.zone.iso8601("1999-12-31")
=> Fri, 31 Dec 1999 00:00:00 HST -10:00
- This new method has stricter semantics than the current `parse` method
+ This new method has stricter semantics than the current `parse` method,
and will raise an `ArgumentError` instead of returning nil, e.g:
>> Time.zone = "Hawaii"
@@ -175,7 +175,9 @@
* Soft-deprecated the top-level `HashWithIndifferentAccess` constant.
`ActiveSupport::HashWithIndifferentAccess` should be used instead.
- *Robin Dupret* (#28157)
+ Fixes #28157.
+
+ *Robin Dupret*
* In Core Extensions, make `MarshalWithAutoloading#load` pass through the second, optional
argument for `Marshal#load( source [, proc] )`. This way we don't have to do