diff options
author | Ryuta Kamizono <kamipo@gmail.com> | 2018-07-31 07:55:39 +0900 |
---|---|---|
committer | GitHub <noreply@github.com> | 2018-07-31 07:55:39 +0900 |
commit | e8dd2bf85716f4aaf3ea4223e748e539589937f6 (patch) | |
tree | 8a31c61488cf73679ac507b5cef3d28277a82cdb /activesupport/test | |
parent | 6db5b6dc4322d043db4d6eff2cc49de86baf1595 (diff) | |
parent | 015477ae9109d4105d5a5057d82338f198febb74 (diff) | |
download | rails-e8dd2bf85716f4aaf3ea4223e748e539589937f6.tar.gz rails-e8dd2bf85716f4aaf3ea4223e748e539589937f6.tar.bz2 rails-e8dd2bf85716f4aaf3ea4223e748e539589937f6.zip |
Merge pull request #33325 from Edouard-chin/ec-deprecate-class-method
A regression in `deprecate_methods` was introduced in a982a42:
Diffstat (limited to 'activesupport/test')
-rw-r--r-- | activesupport/test/deprecation/method_wrappers_test.rb | 35 |
1 files changed, 35 insertions, 0 deletions
diff --git a/activesupport/test/deprecation/method_wrappers_test.rb b/activesupport/test/deprecation/method_wrappers_test.rb index 439e117c1d..b04bce7a11 100644 --- a/activesupport/test/deprecation/method_wrappers_test.rb +++ b/activesupport/test/deprecation/method_wrappers_test.rb @@ -55,4 +55,39 @@ class MethodWrappersTest < ActiveSupport::TestCase assert(@klass.private_method_defined?(:old_private_method)) end + + def test_deprecate_class_method + mod = Module.new do + extend self + + def old_method + "abc" + end + end + ActiveSupport::Deprecation.deprecate_methods(mod, old_method: :new_method) + + warning = /old_method is deprecated and will be removed from Rails \d.\d \(use new_method instead\)/ + assert_deprecated(warning) { assert_equal "abc", mod.old_method } + end + + def test_deprecate_method_when_class_extends_module + mod = Module.new do + def old_method + "abc" + end + end + @klass.extend mod + ActiveSupport::Deprecation.deprecate_methods(mod, old_method: :new_method) + + warning = /old_method is deprecated and will be removed from Rails \d.\d \(use new_method instead\)/ + assert_deprecated(warning) { assert_equal "abc", @klass.old_method } + end + + def test_method_with_without_deprecation_is_exposed + ActiveSupport::Deprecation.deprecate_methods(@klass, old_method: :new_method) + + warning = /old_method is deprecated and will be removed from Rails \d.\d \(use new_method instead\)/ + assert_deprecated(warning) { assert_equal "abc", @klass.new.old_method_with_deprecation } + assert_equal "abc", @klass.new.old_method_without_deprecation + end end |