aboutsummaryrefslogtreecommitdiffstats
path: root/activesupport/test
diff options
context:
space:
mode:
authorCory Gwin @gwincr11 <gwincr11@github.com>2017-11-03 21:26:36 -0400
committerCory Gwin @gwincr11 <gwincr11@github.com>2017-11-17 20:45:43 -0600
commit7b44ffa21efe3b9608254701ffdf44f743b1a324 (patch)
tree14425d4c642443336983ffa7c202650131aaac91 /activesupport/test
parent015239a729d7a247278659e7aa1116a3eddc1dc7 (diff)
downloadrails-7b44ffa21efe3b9608254701ffdf44f743b1a324.tar.gz
rails-7b44ffa21efe3b9608254701ffdf44f743b1a324.tar.bz2
rails-7b44ffa21efe3b9608254701ffdf44f743b1a324.zip
Add support for multiple encodings in String.blank?
Motivation: - When strings are encoded with `.encode("UTF-16LE")` `.blank?` throws an `Encoding::CompatibilityError` exception. - We tested multiple implementation to see what the fastest implementation was, rescueing the execption seems to be the fastest option we could find. Related Issues: - #28953 Changes: - Add a rescue to catch the exception. - Added a `Concurrent::Map` to store a cache of encoded regex objects for requested encoding types. - Use the new `Concurrent::Map` cache to return the correct regex for the string being checked.
Diffstat (limited to 'activesupport/test')
-rw-r--r--activesupport/test/core_ext/object/blank_test.rb4
1 files changed, 2 insertions, 2 deletions
diff --git a/activesupport/test/core_ext/object/blank_test.rb b/activesupport/test/core_ext/object/blank_test.rb
index 749e59ec00..35a3e5922e 100644
--- a/activesupport/test/core_ext/object/blank_test.rb
+++ b/activesupport/test/core_ext/object/blank_test.rb
@@ -16,8 +16,8 @@ class BlankTest < ActiveSupport::TestCase
end
end
- BLANK = [ EmptyTrue.new, nil, false, "", " ", " \n\t \r ", " ", "\u00a0", [], {} ]
- NOT = [ EmptyFalse.new, Object.new, true, 0, 1, "a", [nil], { nil => 0 }, Time.now ]
+ BLANK = [ EmptyTrue.new, nil, false, "", " ", " \n\t \r ", " ", "\u00a0", [], {}, " ".encode("UTF-16LE")]
+ NOT = [ EmptyFalse.new, Object.new, true, 0, 1, "a", [nil], { nil => 0 }, Time.now , "my value".encode("UTF-16LE")]
def test_blank
BLANK.each { |v| assert_equal true, v.blank?, "#{v.inspect} should be blank" }