diff options
author | Miles Georgi <azimux@gmail.com> | 2018-12-06 19:37:00 +0000 |
---|---|---|
committer | Miles Georgi <azimux@gmail.com> | 2018-12-06 20:16:43 +0000 |
commit | 75a2ca6e9dca2c36d80478bcc78ac7bd25bf38f7 (patch) | |
tree | 713bb771b6eb323fc9da80f9ce83c3c1e0c963a5 /activesupport/test | |
parent | b86f65a816546ff8eea39d25b62c995c7efc21dc (diff) | |
download | rails-75a2ca6e9dca2c36d80478bcc78ac7bd25bf38f7.tar.gz rails-75a2ca6e9dca2c36d80478bcc78ac7bd25bf38f7.tar.bz2 rails-75a2ca6e9dca2c36d80478bcc78ac7bd25bf38f7.zip |
HashWithIndifferentAccess#initialize performance improvement
Rails 4 -> Rails 5 introduced a #to_hash call in
HashWithIndifferentAccess#initialize to guarantee access to
the #default and #default_proc methods. This can be a very
expensive operation for very large HashWithIndifferentAccess
objects. This commit bypasses this #to_hash call if it is
already a Hash.
Diffstat (limited to 'activesupport/test')
-rw-r--r-- | activesupport/test/hash_with_indifferent_access_test.rb | 28 |
1 files changed, 28 insertions, 0 deletions
diff --git a/activesupport/test/hash_with_indifferent_access_test.rb b/activesupport/test/hash_with_indifferent_access_test.rb index f81e0dc70f..90f7107b5c 100644 --- a/activesupport/test/hash_with_indifferent_access_test.rb +++ b/activesupport/test/hash_with_indifferent_access_test.rb @@ -828,4 +828,32 @@ class HashWithIndifferentAccessTest < ActiveSupport::TestCase assert_equal 3, hash_wia[:foo] assert_equal 3, hash_wia[:bar] end + + def test_should_copy_the_default_when_converting_non_hash_to_hash_with_indifferent_access + non_hash = Object.new + + def non_hash.to_hash + h = { foo: :bar } + h.default = :baz + h + end + + hash_wia = HashWithIndifferentAccess.new(non_hash) + assert_equal :bar, hash_wia[:foo] + assert_equal :baz, hash_wia[:missing] + end + + def test_should_copy_the_default_proc_when_converting_non_hash_to_hash_with_indifferent_access + non_hash = Object.new + + def non_hash.to_hash + h = { foo: :bar } + h.default_proc = ->(hash, key) { hash[key] = :baz } + h + end + + hash_wia = HashWithIndifferentAccess.new(non_hash) + assert_equal :bar, hash_wia[:foo] + assert_equal :baz, hash_wia[:missing] + end end |