diff options
author | Ignatius Reza <lyoneil.de.sire@gmail.com> | 2017-08-18 09:32:19 +0900 |
---|---|---|
committer | Ignatius Reza <lyoneil.de.sire@gmail.com> | 2017-12-29 10:12:32 +0900 |
commit | 62023884f76c108127c8966f4d67bb717338dd66 (patch) | |
tree | f06fff52fc7f16c3c2c4371d43a55758ee7bdba7 /activesupport/test | |
parent | dab7d401e8dd6192e36787f7b5b574d30b368388 (diff) | |
download | rails-62023884f76c108127c8966f4d67bb717338dd66.tar.gz rails-62023884f76c108127c8966f4d67bb717338dd66.tar.bz2 rails-62023884f76c108127c8966f4d67bb717338dd66.zip |
add instrumentation for read_multi
currently it's not possible to know what the hit rates are from read_multi
Diffstat (limited to 'activesupport/test')
-rw-r--r-- | activesupport/test/cache/cache_store_write_multi_test.rb | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/activesupport/test/cache/cache_store_write_multi_test.rb b/activesupport/test/cache/cache_store_write_multi_test.rb index 5b6fd678c5..7d606e3f7b 100644 --- a/activesupport/test/cache/cache_store_write_multi_test.rb +++ b/activesupport/test/cache/cache_store_write_multi_test.rb @@ -19,7 +19,7 @@ end class CacheStoreWriteMultiInstrumentationTest < ActiveSupport::TestCase setup do - @cache = ActiveSupport::Cache.lookup_store(:null_store) + @cache = ActiveSupport::Cache.lookup_store(:memory_store) end test "instrumentation" do @@ -35,15 +35,15 @@ class CacheStoreWriteMultiInstrumentationTest < ActiveSupport::TestCase end test "instrumentation with fetch_multi as super operation" do - skip "fetch_multi isn't instrumented yet" + @cache.write("b", "bb") - events = with_instrumentation "write_multi" do + events = with_instrumentation "read_multi" do @cache.fetch_multi("a", "b") { |key| key * 2 } end - assert_equal %w[ cache_write_multi.active_support ], events.map(&:name) - assert_nil events[0].payload[:super_operation] - assert !events[0].payload[:hit] + assert_equal %w[ cache_read_multi.active_support ], events.map(&:name) + assert_equal :fetch_multi, events[0].payload[:super_operation] + assert_equal ["b"], events[0].payload[:hits] end private |