diff options
author | Senya <senya@riseup.net> | 2019-07-24 22:39:15 +0300 |
---|---|---|
committer | Senya <senya@riseup.net> | 2019-07-24 22:42:24 +0300 |
commit | 56ec504db6c130d448ffc1d68c9fdd95fdfc1130 (patch) | |
tree | e639d73ef40f242dcdd798bca83a7d11488a2d1e /activesupport/test | |
parent | 01a28f3e6bf9f1550aca9b86b8805051c97a14d6 (diff) | |
download | rails-56ec504db6c130d448ffc1d68c9fdd95fdfc1130.tar.gz rails-56ec504db6c130d448ffc1d68c9fdd95fdfc1130.tar.bz2 rails-56ec504db6c130d448ffc1d68c9fdd95fdfc1130.zip |
Make ActiveSupport::Logger Fiber-safe
Use Fiber.current.__id__ in ActiveSupport::Logger#local_level= in order
to make log level local to Ruby Fibers in addition to Threads.
Diffstat (limited to 'activesupport/test')
-rw-r--r-- | activesupport/test/logger_test.rb | 44 |
1 files changed, 44 insertions, 0 deletions
diff --git a/activesupport/test/logger_test.rb b/activesupport/test/logger_test.rb index 160e1156b6..6f7a186022 100644 --- a/activesupport/test/logger_test.rb +++ b/activesupport/test/logger_test.rb @@ -258,6 +258,50 @@ class LoggerTest < ActiveSupport::TestCase assert_level(Logger::INFO) end + def test_logger_level_main_fiber_safety + @logger.level = Logger::INFO + assert_level(Logger::INFO) + + fiber = Fiber.new do + assert_level(Logger::INFO) + end + + @logger.silence(Logger::ERROR) do + assert_level(Logger::ERROR) + fiber.resume + end + end + + def test_logger_level_local_fiber_safety + @logger.level = Logger::INFO + assert_level(Logger::INFO) + + another_fiber = Fiber.new do + @logger.silence(Logger::ERROR) do + assert_level(Logger::ERROR) + @logger.silence(Logger::DEBUG) do + assert_level(Logger::DEBUG) + end + end + + assert_level(Logger::INFO) + end + + Fiber.new do + @logger.silence(Logger::ERROR) do + assert_level(Logger::ERROR) + @logger.silence(Logger::DEBUG) do + another_fiber.resume + assert_level(Logger::DEBUG) + end + end + + assert_level(Logger::INFO) + end.resume + + assert_level(Logger::INFO) + end + private def level_name(level) ::Logger::Severity.constants.find do |severity| |