diff options
| author | Jordan Thomas <mail@jordanthomas.me> | 2019-04-26 13:29:41 -0400 |
|---|---|---|
| committer | Rafael França <rafaelmfranca@gmail.com> | 2019-04-26 13:29:41 -0400 |
| commit | 4dfdc7eb90be905e0e8e583f942091ce12381b37 (patch) | |
| tree | a002b4d2d55961e379a9cb92a5637937bd0b1d76 /activesupport/test | |
| parent | e281641e51c8ad9d9bc962d9b89bc9119c1ec8fb (diff) | |
| download | rails-4dfdc7eb90be905e0e8e583f942091ce12381b37.tar.gz rails-4dfdc7eb90be905e0e8e583f942091ce12381b37.tar.bz2 rails-4dfdc7eb90be905e0e8e583f942091ce12381b37.zip | |
Frozen truncate (#36109)
* Add test asserting truncate returns unfrozen string
* Ensure strings returned from truncate are not frozen
This fixes an issue where strings too short to be truncated were
returned unfrozen, where as long-enough strings were returned
frozen. Now retuned strings will not be frozen whether or not
the string returned was shortened.
* Update changelog w/ new truncate behavior description
[Jordan Thomas + Rafael Mendonça França]
Diffstat (limited to 'activesupport/test')
| -rw-r--r-- | activesupport/test/core_ext/string_ext_test.rb | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/activesupport/test/core_ext/string_ext_test.rb b/activesupport/test/core_ext/string_ext_test.rb index 4ffa33aa61..c5a000b67a 100644 --- a/activesupport/test/core_ext/string_ext_test.rb +++ b/activesupport/test/core_ext/string_ext_test.rb @@ -291,6 +291,11 @@ class StringInflectionsTest < ActiveSupport::TestCase assert_equal "Hello Big[...]", "Hello Big World!".truncate(15, omission: "[...]", separator: /\s/) end + def test_truncate_returns_frozen_string + assert_not "Hello World!".truncate(12).frozen? + assert_not "Hello World!!".truncate(12).frozen? + end + def test_truncate_bytes assert_equal "ππππ", "ππππ".truncate_bytes(16) assert_equal "ππππ", "ππππ".truncate_bytes(16, omission: nil) |