diff options
author | Kasper Timm Hansen <kaspth@gmail.com> | 2019-06-06 15:43:52 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2019-06-06 15:43:52 +0200 |
commit | 480d9f2d2431e6a11c89edb45123181f9b6db958 (patch) | |
tree | 33c0448be93ec8080f7fe57b40284e955d6a434f /activesupport/test | |
parent | 66ee39be6d4583980595ff53319d8f36a36d8813 (diff) | |
parent | a5502f4a795d6d34d4f05eeefc9f9a653eff0eb0 (diff) | |
download | rails-480d9f2d2431e6a11c89edb45123181f9b6db958.tar.gz rails-480d9f2d2431e6a11c89edb45123181f9b6db958.tar.bz2 rails-480d9f2d2431e6a11c89edb45123181f9b6db958.zip |
Merge pull request #36270 from Edouard-chin/ec-on-rotation-constructor
Allow `on_rotation` in MessageEncryptor to be passed in constructor:
Diffstat (limited to 'activesupport/test')
-rw-r--r-- | activesupport/test/message_encryptor_test.rb | 28 |
1 files changed, 28 insertions, 0 deletions
diff --git a/activesupport/test/message_encryptor_test.rb b/activesupport/test/message_encryptor_test.rb index 9edf07f762..097aa8b5f8 100644 --- a/activesupport/test/message_encryptor_test.rb +++ b/activesupport/test/message_encryptor_test.rb @@ -171,6 +171,34 @@ class MessageEncryptorTest < ActiveSupport::TestCase assert rotated end + def test_on_rotation_can_be_passed_at_the_constructor_level + older_message = ActiveSupport::MessageEncryptor.new(secrets[:older], "older sign").encrypt_and_sign(encoded: "message") + + rotated = false + encryptor = ActiveSupport::MessageEncryptor.new(@secret, on_rotation: proc { rotated = true }) + encryptor.rotate secrets[:older], "older sign" + + assert_changes(:rotated, from: false, to: true) do + message = encryptor.decrypt_and_verify(older_message) + + assert_equal({ encoded: "message" }, message) + end + end + + def test_on_rotation_option_takes_precedence_over_the_one_given_in_constructor + older_message = ActiveSupport::MessageEncryptor.new(secrets[:older], "older sign").encrypt_and_sign(encoded: "message") + + rotated = false + encryptor = ActiveSupport::MessageEncryptor.new(@secret, on_rotation: proc { rotated = true }) + encryptor.rotate secrets[:older], "older sign" + + assert_changes(:rotated, from: false, to: "Yes") do + message = encryptor.decrypt_and_verify(older_message, on_rotation: proc { rotated = "Yes" }) + + assert_equal({ encoded: "message" }, message) + end + end + def test_with_rotated_metadata old_message = ActiveSupport::MessageEncryptor.new(secrets[:old], cipher: "aes-256-gcm"). encrypt_and_sign("metadata", purpose: :rotation) |