diff options
author | José Valim <jose.valim@gmail.com> | 2011-11-21 22:07:24 +0000 |
---|---|---|
committer | José Valim <jose.valim@gmail.com> | 2011-11-21 22:17:35 +0000 |
commit | 401393b6561adc1ce7101945163c9601257c057a (patch) | |
tree | 1b5e083d96af5cbafd6914144071158de6236a3d /activesupport/test | |
parent | f312e2142b59b39637ab3d668876c3babac22087 (diff) | |
download | rails-401393b6561adc1ce7101945163c9601257c057a.tar.gz rails-401393b6561adc1ce7101945163c9601257c057a.tar.bz2 rails-401393b6561adc1ce7101945163c9601257c057a.zip |
Deprecate InstanceMethods namespace handling in ActiveSupport::Concern.
This avoids the unnecessary "yo dawg, I heard you like include, so I put a module that includes your module when it is included" approach when building extensions.
Diffstat (limited to 'activesupport/test')
-rw-r--r-- | activesupport/test/concern_test.rb | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/activesupport/test/concern_test.rb b/activesupport/test/concern_test.rb index 4cbe56a2d2..0b0920ee03 100644 --- a/activesupport/test/concern_test.rb +++ b/activesupport/test/concern_test.rb @@ -19,9 +19,6 @@ class ConcernTest < Test::Unit::TestCase end end - module InstanceMethods - end - included do self.included_ran = true end @@ -74,7 +71,7 @@ class ConcernTest < Test::Unit::TestCase def test_instance_methods_are_included @klass.send(:include, Baz) assert_equal "baz", @klass.new.baz - assert @klass.included_modules.include?(ConcernTest::Baz::InstanceMethods) + assert @klass.included_modules.include?(ConcernTest::Baz) end def test_included_block_is_ran @@ -92,6 +89,6 @@ class ConcernTest < Test::Unit::TestCase def test_dependencies_with_multiple_modules @klass.send(:include, Foo) - assert_equal [ConcernTest::Foo, ConcernTest::Bar, ConcernTest::Baz::InstanceMethods, ConcernTest::Baz], @klass.included_modules[0..3] + assert_equal [ConcernTest::Foo, ConcernTest::Bar, ConcernTest::Baz], @klass.included_modules[0..2] end end |