aboutsummaryrefslogtreecommitdiffstats
path: root/activesupport/test
diff options
context:
space:
mode:
authorArthur Nogueira Neves <github@arthurnn.com>2015-03-23 20:07:42 -0400
committerArthur Nogueira Neves <github@arthurnn.com>2015-03-23 20:07:42 -0400
commit2f14153a53fd3b39ca98b5871a33367105c38b0a (patch)
tree6fb4f6f4502590dc16d75f5cb3be33a53b080e5d /activesupport/test
parent503d9e12887e21015f9b241944dd850614c3e1b3 (diff)
parenta64f3e419598bce0ce2eb9e41dcccb676edb02e2 (diff)
downloadrails-2f14153a53fd3b39ca98b5871a33367105c38b0a.tar.gz
rails-2f14153a53fd3b39ca98b5871a33367105c38b0a.tar.bz2
rails-2f14153a53fd3b39ca98b5871a33367105c38b0a.zip
Merge pull request #19481 from davidcornu/activesupport/normalize-to-sentence
Make sure Array#to_sentence always returns a String
Diffstat (limited to 'activesupport/test')
-rw-r--r--activesupport/test/core_ext/array/conversions_test.rb6
1 files changed, 6 insertions, 0 deletions
diff --git a/activesupport/test/core_ext/array/conversions_test.rb b/activesupport/test/core_ext/array/conversions_test.rb
index 577b889410..507e13f968 100644
--- a/activesupport/test/core_ext/array/conversions_test.rb
+++ b/activesupport/test/core_ext/array/conversions_test.rb
@@ -60,6 +60,12 @@ class ToSentenceTest < ActiveSupport::TestCase
assert_equal exception.message, "Unknown key: :passing. Valid keys are: :words_connector, :two_words_connector, :last_word_connector, :locale"
end
+
+ def test_always_returns_string
+ assert_instance_of String, [ActiveSupport::SafeBuffer.new('one')].to_sentence
+ assert_instance_of String, [ActiveSupport::SafeBuffer.new('one'), 'two'].to_sentence
+ assert_instance_of String, [ActiveSupport::SafeBuffer.new('one'), 'two', 'three'].to_sentence
+ end
end
class ToSTest < ActiveSupport::TestCase