aboutsummaryrefslogtreecommitdiffstats
path: root/activesupport/test
diff options
context:
space:
mode:
authorCliff Pruitt <cliff.pruitt@cliffpruitt.com>2019-07-16 14:41:51 -0400
committerCliff Pruitt <cliff.pruitt@cliffpruitt.com>2019-07-16 14:51:57 -0400
commit05f9e3ef92114c2df978009073d0b47fe1323eb7 (patch)
tree2bfb7197f1bc81ed23628c6e2828631fd3cd8c26 /activesupport/test
parent85b422bd7fcb93c6a3d13f78fca55b85f69865a1 (diff)
downloadrails-05f9e3ef92114c2df978009073d0b47fe1323eb7.tar.gz
rails-05f9e3ef92114c2df978009073d0b47fe1323eb7.tar.bz2
rails-05f9e3ef92114c2df978009073d0b47fe1323eb7.zip
Make UTF-8 string requirement explicit for `transliterate`
It's noted in #34062 that String#parameterize will raise an `Encoding::CompatibilityError` if the string is not UTF-8 encoded. The error is raised as a result of passing the string to `.unicode_normalize`. This PR raises a higher level `ArgumentError` if the provided string is not UTF-8 and updates documentation to note the encoding requirement.
Diffstat (limited to 'activesupport/test')
-rw-r--r--activesupport/test/transliterate_test.rb8
1 files changed, 8 insertions, 0 deletions
diff --git a/activesupport/test/transliterate_test.rb b/activesupport/test/transliterate_test.rb
index 9e29a93ea0..525b4a8559 100644
--- a/activesupport/test/transliterate_test.rb
+++ b/activesupport/test/transliterate_test.rb
@@ -57,4 +57,12 @@ class TransliterateTest < ActiveSupport::TestCase
end
assert_equal "Can only transliterate strings. Received Object", exception.message
end
+
+ def test_transliterate_handles_non_unicode_strings
+ ascii_8bit_string = "A".b
+ exception = assert_raises ArgumentError do
+ assert_equal "A", ActiveSupport::Inflector.transliterate(ascii_8bit_string)
+ end
+ assert_equal "Can only transliterate UTF-8 strings. Received string with encoding ASCII-8BIT", exception.message
+ end
end