aboutsummaryrefslogtreecommitdiffstats
path: root/activesupport/test/subscriber_test.rb
diff options
context:
space:
mode:
authorDennis Schoen <dennis.schoen@xing.com>2014-05-09 11:16:18 +0200
committerDennis Schoen <dennis.schoen@xing.com>2014-05-09 11:16:18 +0200
commitb50468d13dfc5d9ba1abe9b097d80b0191f6933f (patch)
tree841bb47b982aa27cc55063cb994a4118388526ae /activesupport/test/subscriber_test.rb
parent83e0544204a1b0125af15e1ea0e54aa30b2266ab (diff)
downloadrails-b50468d13dfc5d9ba1abe9b097d80b0191f6933f.tar.gz
rails-b50468d13dfc5d9ba1abe9b097d80b0191f6933f.tar.bz2
rails-b50468d13dfc5d9ba1abe9b097d80b0191f6933f.zip
Fixed duplicate subscribers in ActiveSupport::Subscriber
ActiveSupport::Subscriber no longer creates multiple subscribers when you redefine a method.
Diffstat (limited to 'activesupport/test/subscriber_test.rb')
-rw-r--r--activesupport/test/subscriber_test.rb25
1 files changed, 19 insertions, 6 deletions
diff --git a/activesupport/test/subscriber_test.rb b/activesupport/test/subscriber_test.rb
index 253411aa3d..8be8c51f07 100644
--- a/activesupport/test/subscriber_test.rb
+++ b/activesupport/test/subscriber_test.rb
@@ -4,20 +4,27 @@ require 'active_support/subscriber'
class TestSubscriber < ActiveSupport::Subscriber
attach_to :doodle
- cattr_reader :event
+ cattr_reader :events
def self.clear
- @@event = nil
+ @@events = []
end
def open_party(event)
- @@event = event
+ events << event
end
private
def private_party(event)
- @@event = event
+ events << event
+ end
+end
+
+# Monkey patch subscriber to test that only one subscriber per method is added.
+class TestSubscriber
+ def open_party(event)
+ events << event
end
end
@@ -29,12 +36,18 @@ class SubscriberTest < ActiveSupport::TestCase
def test_attaches_subscribers
ActiveSupport::Notifications.instrument("open_party.doodle")
- assert_equal "open_party.doodle", TestSubscriber.event.name
+ assert_equal "open_party.doodle", TestSubscriber.events.first.name
+ end
+
+ def test_attaches_only_one_subscriber
+ ActiveSupport::Notifications.instrument("open_party.doodle")
+
+ assert_equal 1, TestSubscriber.events.size
end
def test_does_not_attach_private_methods
ActiveSupport::Notifications.instrument("private_party.doodle")
- assert_nil TestSubscriber.event
+ assert_equal TestSubscriber.events, []
end
end