diff options
| author | Neil Souza <neil@ztkae.com> | 2017-07-26 19:13:13 +0800 |
|---|---|---|
| committer | Gannon McGibbon <gannon.mcgibbon@shopify.com> | 2018-05-04 10:47:18 -0400 |
| commit | bfddb67197bf0b5c6ec17e2a35ece9190bec8bac (patch) | |
| tree | d159d902adcc478ea82939cab161aa4201e7f10a /activesupport/test/lazy_load_hooks_test.rb | |
| parent | 98c1432583d4607af1467425183d8d448a692c5a (diff) | |
| download | rails-bfddb67197bf0b5c6ec17e2a35ece9190bec8bac.tar.gz rails-bfddb67197bf0b5c6ec17e2a35ece9190bec8bac.tar.bz2 rails-bfddb67197bf0b5c6ec17e2a35ece9190bec8bac.zip | |
Fix #29632 - nil #path leads to NoMethodError in LoadError#is_missing?
See #29632 for details. In short, it's possible to enter `LoadError#is_missing?` when `LoadError#path` returns `nil`, leading to `path.sub` throwing an none-to-helpful `NoMethodError`.
This tiniest of patch inserts `#to_s` before the `sub` call to make sure it succeeds. Affected surface area should be just as tiny since something has already gone wrong to get us into `#is_missing?` and the current behavior when `#path` returns `nil` seems clearly not intended.
[Gannon McGibbon + Neil Souza]
Diffstat (limited to 'activesupport/test/lazy_load_hooks_test.rb')
0 files changed, 0 insertions, 0 deletions