diff options
author | Jon Rowe <hello@jonrowe.co.uk> | 2012-03-15 12:21:20 +0000 |
---|---|---|
committer | Jon Rowe <hello@jonrowe.co.uk> | 2012-03-15 12:21:20 +0000 |
commit | 4073505065a0937d67c45860988fbe634a700c37 (patch) | |
tree | 847447d1262067ee8392d96bdbfe9ed8b9baa50f /activesupport/test/file_update_checker_test.rb | |
parent | fbc9d0f44f090a9873834f4966760c3e80682559 (diff) | |
download | rails-4073505065a0937d67c45860988fbe634a700c37.tar.gz rails-4073505065a0937d67c45860988fbe634a700c37.tar.bz2 rails-4073505065a0937d67c45860988fbe634a700c37.zip |
escape commas in paths before globbing to avoid infinite hang in Dir[]
Diffstat (limited to 'activesupport/test/file_update_checker_test.rb')
-rw-r--r-- | activesupport/test/file_update_checker_test.rb | 15 |
1 files changed, 15 insertions, 0 deletions
diff --git a/activesupport/test/file_update_checker_test.rb b/activesupport/test/file_update_checker_test.rb index dd2483287b..c884068c59 100644 --- a/activesupport/test/file_update_checker_test.rb +++ b/activesupport/test/file_update_checker_test.rb @@ -1,5 +1,6 @@ require 'abstract_unit' require 'fileutils' +require 'thread' MTIME_FIXTURES_PATH = File.expand_path("../fixtures", __FILE__) @@ -79,4 +80,18 @@ class FileUpdateCheckerWithEnumerableTest < ActiveSupport::TestCase assert !checker.execute_if_updated assert_equal 0, i end + + def test_should_not_block_if_a_strange_filename_used + FileUtils.mkdir_p("tmp_watcher/valid,yetstrange,path,") + FileUtils.touch(FILES.map { |file_name| "tmp_watcher/valid,yetstrange,path,/#{file_name}" } ) + + test = Thread.new do + checker = ActiveSupport::FileUpdateChecker.new([],"tmp_watcher/valid,yetstrange,path," => :txt){ i += 1 } + Thread.exit + end + test.priority = -1 + test.join(5) + + assert !test.alive? + end end |