diff options
author | Fumiaki MATSUSHIMA <mtsmfm@gmail.com> | 2017-03-15 23:57:45 +0900 |
---|---|---|
committer | Fumiaki MATSUSHIMA <mtsmfm@gmail.com> | 2017-03-16 00:19:21 +0900 |
commit | e9b638fda5bf14132ce9cd469a72e4a777215846 (patch) | |
tree | 97a53f47847ca9be8c32fa4bd6cf43f1fe0b8812 /activesupport/lib | |
parent | e79a991ccfdf3b7b56562be35b996e61d7395861 (diff) | |
download | rails-e9b638fda5bf14132ce9cd469a72e4a777215846.tar.gz rails-e9b638fda5bf14132ce9cd469a72e4a777215846.tar.bz2 rails-e9b638fda5bf14132ce9cd469a72e4a777215846.zip |
Fix fragile test (`AssociationProxyTest#test_save_on_parent_saves_children`)
If we run only following tests:
- test/cases/scoping/default_scoping_test.rb
- test/cases/associations_test.rb
```
$ cat Rakefile.test
require "rake/testtask"
ENV["ARCONN"] = "postgresql"
Rake::TestTask.new do |t|
t.libs << "test"
t.test_files = %w(
test/cases/scoping/default_scoping_test.rb
test/cases/associations_test.rb
)
end
```
a test will fail:
```
$ bundle exec rake test -f Rakefile.test
/app/activesupport/lib/active_support/core_ext/enumerable.rb:20: warning: method redefined; discarding old sum
Using postgresql
Run options: --seed 11830
# Running:
.........................................................................................F................
Finished in 6.939055s, 15.2759 runs/s, 27.9577 assertions/s.
1) Failure:
AssociationProxyTest#test_save_on_parent_saves_children [/app/activerecord/test/cases/associations_test.rb:185]:
Expected: 1
Actual: 2
106 runs, 194 assertions, 1 failures, 0 errors, 0 skips
rake aborted!
Command failed with status (1)
/usr/local/bin/bundle:22:in `load'
/usr/local/bin/bundle:22:in `<main>'
Tasks: TOP => test
(See full trace by running task with --trace)
```
In #28083, change `self.use_transactional_tests` to `false`
but we forget to clean-up fixture.
However we don't have to disable transaction except a few tests.
Diffstat (limited to 'activesupport/lib')
0 files changed, 0 insertions, 0 deletions