diff options
author | Santiago Pastorino <santiago@wyeworks.com> | 2012-06-17 08:11:47 -0700 |
---|---|---|
committer | Santiago Pastorino <santiago@wyeworks.com> | 2012-06-17 08:11:47 -0700 |
commit | 625c4959573c608140005425ff709422b35ba6a3 (patch) | |
tree | 9b03e2449a1c5a0235535d1f99a3e2500fae0bc5 /activesupport/lib | |
parent | ebe9679d9424fbc06f6f870d9003cd20fbc130af (diff) | |
parent | c9891608aa1e5ebbab04afe73bf7a28748001804 (diff) | |
download | rails-625c4959573c608140005425ff709422b35ba6a3.tar.gz rails-625c4959573c608140005425ff709422b35ba6a3.tar.bz2 rails-625c4959573c608140005425ff709422b35ba6a3.zip |
Merge pull request #6759 from dylanahsmith/only-catch-standard-error
Avoid unnecessary catching of Exception instead of StandardError.
Diffstat (limited to 'activesupport/lib')
-rw-r--r-- | activesupport/lib/active_support/log_subscriber.rb | 2 | ||||
-rw-r--r-- | activesupport/lib/active_support/multibyte/unicode.rb | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/activesupport/lib/active_support/log_subscriber.rb b/activesupport/lib/active_support/log_subscriber.rb index bea2ca17f1..d5f0e3fa6c 100644 --- a/activesupport/lib/active_support/log_subscriber.rb +++ b/activesupport/lib/active_support/log_subscriber.rb @@ -92,7 +92,7 @@ module ActiveSupport method = message.split('.').first begin send(method, ActiveSupport::Notifications::Event.new(message, *args)) - rescue Exception => e + rescue => e logger.error "Could not log #{message.inspect} event. #{e.class}: #{e.message} #{e.backtrace}" end end diff --git a/activesupport/lib/active_support/multibyte/unicode.rb b/activesupport/lib/active_support/multibyte/unicode.rb index 678f551193..ef1711c60a 100644 --- a/activesupport/lib/active_support/multibyte/unicode.rb +++ b/activesupport/lib/active_support/multibyte/unicode.rb @@ -331,7 +331,7 @@ module ActiveSupport def load begin @codepoints, @composition_exclusion, @composition_map, @boundary, @cp1252 = File.open(self.class.filename, 'rb') { |f| Marshal.load f.read } - rescue Exception => e + rescue => e raise IOError.new("Couldn't load the Unicode tables for UTF8Handler (#{e.message}), ActiveSupport::Multibyte is unusable") end |