aboutsummaryrefslogtreecommitdiffstats
path: root/activesupport/lib
diff options
context:
space:
mode:
authorBrent Wheeldon <brent.wheeldon@gmail.com>2017-11-02 14:53:43 -0400
committerBrent Wheeldon <brent.wheeldon@gmail.com>2017-11-09 10:46:01 -0500
commit1f9f6f6cfc57020ccb35f77872c56f069f337075 (patch)
tree0bcd80358ffba33786a77af6134ecbd436bcf03a /activesupport/lib
parenteae65ac2ab7e7a8155fa5a76c15f21cee09499c2 (diff)
downloadrails-1f9f6f6cfc57020ccb35f77872c56f069f337075.tar.gz
rails-1f9f6f6cfc57020ccb35f77872c56f069f337075.tar.bz2
rails-1f9f6f6cfc57020ccb35f77872c56f069f337075.zip
Prevent deadlocks with load interlock and DB lock.
This fixes an issue where competing threads deadlock each other. - Thread A holds the load interlock but is blocked on getting the DB lock - Thread B holds the DB lock but is blocked on getting the load interlock (for example when there is a `Model.transaction` block that needs to autoload) This solution allows for dependency loading in other threads while a thread is waiting to acquire the DB lock. Fixes #31019
Diffstat (limited to 'activesupport/lib')
-rw-r--r--activesupport/lib/active_support/concurrency/load_interlock_aware_monitor.rb17
1 files changed, 17 insertions, 0 deletions
diff --git a/activesupport/lib/active_support/concurrency/load_interlock_aware_monitor.rb b/activesupport/lib/active_support/concurrency/load_interlock_aware_monitor.rb
new file mode 100644
index 0000000000..a8455c0048
--- /dev/null
+++ b/activesupport/lib/active_support/concurrency/load_interlock_aware_monitor.rb
@@ -0,0 +1,17 @@
+# frozen_string_literal: true
+
+require "monitor"
+
+module ActiveSupport
+ module Concurrency
+ # A monitor that will permit dependency loading while blocked waiting for
+ # the lock.
+ class LoadInterlockAwareMonitor < Monitor
+ # Enters an exclusive section, but allows dependency loading while blocked
+ def mon_enter
+ mon_try_enter ||
+ ActiveSupport::Dependencies.interlock.permit_concurrent_loads { super }
+ end
+ end
+ end
+end