diff options
author | Vijay Dev <vijaydev.cse@gmail.com> | 2014-02-09 23:33:55 +0530 |
---|---|---|
committer | Vijay Dev <vijaydev.cse@gmail.com> | 2014-02-09 23:33:55 +0530 |
commit | 92fdd6516287f677cd6687e5c31298fa68931baa (patch) | |
tree | 4dcf9071b9f5940974bac3168357151cf92c340b /activesupport/lib/active_support | |
parent | 33be58b2060b1e859e8da370b911822c20028690 (diff) | |
parent | ae7580ac287df477e7f5dd57136d5eec3813629d (diff) | |
download | rails-92fdd6516287f677cd6687e5c31298fa68931baa.tar.gz rails-92fdd6516287f677cd6687e5c31298fa68931baa.tar.bz2 rails-92fdd6516287f677cd6687e5c31298fa68931baa.zip |
Merge branch 'master' of github.com:rails/docrails
Conflicts:
guides/source/active_record_validations.md
guides/source/api_documentation_guidelines.md
guides/source/configuring.md
Diffstat (limited to 'activesupport/lib/active_support')
-rw-r--r-- | activesupport/lib/active_support/core_ext/module/attr_internal.rb | 3 | ||||
-rw-r--r-- | activesupport/lib/active_support/dependencies.rb | 3 |
2 files changed, 4 insertions, 2 deletions
diff --git a/activesupport/lib/active_support/core_ext/module/attr_internal.rb b/activesupport/lib/active_support/core_ext/module/attr_internal.rb index db07d549b0..67f0e0335d 100644 --- a/activesupport/lib/active_support/core_ext/module/attr_internal.rb +++ b/activesupport/lib/active_support/core_ext/module/attr_internal.rb @@ -27,7 +27,8 @@ class Module def attr_internal_define(attr_name, type) internal_name = attr_internal_ivar_name(attr_name).sub(/\A@/, '') - class_eval do # class_eval is necessary on 1.9 or else the methods a made private + # class_eval is necessary on 1.9 or else the methods are made private + class_eval do # use native attr_* methods as they are faster on some Ruby implementations send("attr_#{type}", internal_name) end diff --git a/activesupport/lib/active_support/dependencies.rb b/activesupport/lib/active_support/dependencies.rb index 7ea3ff7d3f..59675d744e 100644 --- a/activesupport/lib/active_support/dependencies.rb +++ b/activesupport/lib/active_support/dependencies.rb @@ -407,7 +407,8 @@ module ActiveSupport #:nodoc: end def load_once_path?(path) - # to_s works around a ruby1.9 issue where #starts_with?(Pathname) will always return false + # to_s works around a ruby1.9 issue where String#starts_with?(Pathname) + # will raise a TypeError: no implicit conversion of Pathname into String autoload_once_paths.any? { |base| path.starts_with? base.to_s } end |