aboutsummaryrefslogtreecommitdiffstats
path: root/activesupport/lib/active_support/ordered_options.rb
diff options
context:
space:
mode:
authorVladimir Dementyev <dementiev.vm@gmail.com>2019-01-22 14:05:32 -0500
committerVladimir Dementyev <dementiev.vm@gmail.com>2019-01-22 15:14:20 -0500
commitdc80459a9e9a6088668f93c9f44be4c170193fb7 (patch)
tree64e73600542483afb863c03e5e8ee247c81d187d /activesupport/lib/active_support/ordered_options.rb
parent1d359d4bf6775585b0a488678dac3d8b5ff9c634 (diff)
downloadrails-dc80459a9e9a6088668f93c9f44be4c170193fb7.tar.gz
rails-dc80459a9e9a6088668f93c9f44be4c170193fb7.tar.bz2
rails-dc80459a9e9a6088668f93c9f44be4c170193fb7.zip
Move `channel_name` to Channel.broadcasting_for
That would allow us to test broadcasting made with channel, e.g.: ```ruby class ChatRelayJob < ApplicationJob def perform_later(room, msg) ChatChannel.broadcast_to room, message: msg end end ``` To test this functionality we need to know the underlying stream name (to use `assert_broadcasts`), which relies on `channel_name`. We had to use the following code: ```ruby assert_broadcasts(ChatChannel.broadcasting_for([ChatChannel.channel_name, room]), 1) do ChatRelayJob.perform_now end ``` The problem with this approach is that we use _internal_ API (we shouldn't care about `channel_name` prefix in our code). With this commit we could re-write the test as following: ```ruby assert_broadcasts(ChatChannel.broadcasting_for(room), 1) do ChatRelayJob.perform_now end ```
Diffstat (limited to 'activesupport/lib/active_support/ordered_options.rb')
0 files changed, 0 insertions, 0 deletions