diff options
| author | Vipul A M <vipulnsward@gmail.com> | 2013-10-14 23:52:06 +0530 |
|---|---|---|
| committer | Vipul A M <vipulnsward@gmail.com> | 2013-10-14 23:52:06 +0530 |
| commit | 67c2525d59f8136c648bc59c5c39dbab77713fe2 (patch) | |
| tree | f51ac945aea4fe54c9d2ceb2694a5e2d3246234b /activesupport/lib/active_support/number_helper.rb | |
| parent | 42a99dbaba3f9968f800d24dfdb60c51bee091b1 (diff) | |
| download | rails-67c2525d59f8136c648bc59c5c39dbab77713fe2.tar.gz rails-67c2525d59f8136c648bc59c5c39dbab77713fe2.tar.bz2 rails-67c2525d59f8136c648bc59c5c39dbab77713fe2.zip | |
Minor Refactoring to `NumberHelper#number_to_human`
* Use destructive `map` and `sort_by` to save extra object creation.
* Create `INVERTED_DECIMAL_UNITS.invert` constant instead of repeatedly doing `DECIMAL_UNITS.invert`
Diffstat (limited to 'activesupport/lib/active_support/number_helper.rb')
| -rw-r--r-- | activesupport/lib/active_support/number_helper.rb | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/activesupport/lib/active_support/number_helper.rb b/activesupport/lib/active_support/number_helper.rb index c9c0eff2bf..e0151baa36 100644 --- a/activesupport/lib/active_support/number_helper.rb +++ b/activesupport/lib/active_support/number_helper.rb @@ -108,7 +108,7 @@ module ActiveSupport DECIMAL_UNITS = { 0 => :unit, 1 => :ten, 2 => :hundred, 3 => :thousand, 6 => :million, 9 => :billion, 12 => :trillion, 15 => :quadrillion, -1 => :deci, -2 => :centi, -3 => :mili, -6 => :micro, -9 => :nano, -12 => :pico, -15 => :femto } - + INVERTED_DECIMAL_UNITS = DECIMAL_UNITS.invert STORAGE_UNITS = [:byte, :kb, :mb, :gb, :tb] # Formats a +number+ into a US phone number (e.g., (555) @@ -561,8 +561,6 @@ module ActiveSupport #for backwards compatibility with those that didn't add strip_insignificant_zeros to their locale files options[:strip_insignificant_zeros] = true if not options.key?(:strip_insignificant_zeros) - inverted_du = DECIMAL_UNITS.invert - units = options.delete :units unit_exponents = case units when Hash @@ -573,7 +571,7 @@ module ActiveSupport translate_number_value_with_default("human.decimal_units.units", :locale => options[:locale], :raise => true) else raise ArgumentError, ":units must be a Hash or String translation scope." - end.keys.map{|e_name| inverted_du[e_name] }.sort_by{|e| -e} + end.keys.map!{|e_name| INVERTED_DECIMAL_UNITS[e_name] }.sort_by!{|e| -e} number_exponent = number != 0 ? Math.log10(number.abs).floor : 0 display_exponent = unit_exponents.find{ |e| number_exponent >= e } || 0 |