aboutsummaryrefslogtreecommitdiffstats
path: root/activesupport/lib/active_support/core_ext
diff options
context:
space:
mode:
authorJosé Valim <jose.valim@gmail.com>2011-12-22 09:22:32 -0800
committerJosé Valim <jose.valim@gmail.com>2011-12-22 09:22:32 -0800
commite003bafc116c8f8285653047388923500a2cc13f (patch)
treebb1cb572b6a600e35995619806829902b12f6781 /activesupport/lib/active_support/core_ext
parent6def76db7b92efc5e301503d542db0d62d3d8284 (diff)
parentc4df2d0b6e0c1f4e0df4a66bfae91a684f3d9f71 (diff)
downloadrails-e003bafc116c8f8285653047388923500a2cc13f.tar.gz
rails-e003bafc116c8f8285653047388923500a2cc13f.tar.bz2
rails-e003bafc116c8f8285653047388923500a2cc13f.zip
Merge pull request #4135 from nashby/deprecate-uniq-by
deprecate Array#uniq_by and Array#uniq_by!
Diffstat (limited to 'activesupport/lib/active_support/core_ext')
-rw-r--r--activesupport/lib/active_support/core_ext/array/uniq_by.rb14
1 files changed, 8 insertions, 6 deletions
diff --git a/activesupport/lib/active_support/core_ext/array/uniq_by.rb b/activesupport/lib/active_support/core_ext/array/uniq_by.rb
index 9c5f97b0e9..edc164dabd 100644
--- a/activesupport/lib/active_support/core_ext/array/uniq_by.rb
+++ b/activesupport/lib/active_support/core_ext/array/uniq_by.rb
@@ -3,14 +3,16 @@ class Array
#
# [1, 2, 3, 4].uniq_by { |i| i.odd? } # => [1, 2]
#
- def uniq_by
- hash, array = {}, []
- each { |i| hash[yield(i)] ||= (array << i) }
- array
+ def uniq_by(&block)
+ ActiveSupport::Deprecation.warn "uniq_by " \
+ "is deprecated. Use Array#uniq instead", caller
+ uniq(&block)
end
# Same as uniq_by, but modifies self.
- def uniq_by!
- replace(uniq_by{ |i| yield(i) })
+ def uniq_by!(&block)
+ ActiveSupport::Deprecation.warn "uniq_by! " \
+ "is deprecated. Use Array#uniq! instead", caller
+ uniq!(&block)
end
end