aboutsummaryrefslogtreecommitdiffstats
path: root/activesupport/lib/active_support/core_ext/kernel/reporting.rb
diff options
context:
space:
mode:
authorMario Visic <mario@mariovisic.com>2013-10-29 13:04:04 +1100
committerMario Visic <mario@mariovisic.com>2013-12-06 10:24:06 +1100
commitffe99774bb0b64644dc419ba83d131218854d404 (patch)
tree8886f4bd9a889d828410d1bf8d43f0fed2afa4db /activesupport/lib/active_support/core_ext/kernel/reporting.rb
parentdbdbda9a4a5cb9cd22e7a5a5625caa84edae6d5d (diff)
downloadrails-ffe99774bb0b64644dc419ba83d131218854d404.tar.gz
rails-ffe99774bb0b64644dc419ba83d131218854d404.tar.bz2
rails-ffe99774bb0b64644dc419ba83d131218854d404.zip
Fix issue with Kernel#silence_stream leaking file descriptors
Calling Kernel#silence_stream creates a new file descriptor which isn't closed after it is used. As a result calling silence_stream multiple times leads to a build up of loose file descriptors and can cause issues in environments where garbage collection isn't run often.
Diffstat (limited to 'activesupport/lib/active_support/core_ext/kernel/reporting.rb')
-rw-r--r--activesupport/lib/active_support/core_ext/kernel/reporting.rb1
1 files changed, 1 insertions, 0 deletions
diff --git a/activesupport/lib/active_support/core_ext/kernel/reporting.rb b/activesupport/lib/active_support/core_ext/kernel/reporting.rb
index df11737a6b..3b5e205244 100644
--- a/activesupport/lib/active_support/core_ext/kernel/reporting.rb
+++ b/activesupport/lib/active_support/core_ext/kernel/reporting.rb
@@ -48,6 +48,7 @@ module Kernel
yield
ensure
stream.reopen(old_stream)
+ old_stream.close
end
# Blocks and ignores any exception passed as argument if raised within the block.