Merge branch 'master' of https://github.com/rails/rails

1 files changed, 29 insertions, 7 deletions

diff --git a/activesupport/lib/active_support/core_ext/class/attribute.rb b/activesupport/lib/active_support/core_ext/class/attribute.rb
index bfa57fe1f7..5414b3a18f 100644
--- a/activesupport/lib/active_support/core_ext/class/attribute.rb
+++ b/activesupport/lib/active_support/core_ext/class/attribute.rb
@@ -29,19 +29,19 @@ class Class
   # In such cases, you don't want to do changes in places but use setters:
   #
   #   Base.setting = []
-  #   Base.setting                #=> []
-  #   Subclass.setting            #=> []
+  #   Base.setting                # => []
+  #   Subclass.setting            # => []
   #
   #   # Appending in child changes both parent and child because it is the same object:
   #   Subclass.setting << :foo
-  #   Base.setting               #=> [:foo]
-  #   Subclass.setting           #=> [:foo]
+  #   Base.setting               # => [:foo]
+  #   Subclass.setting           # => [:foo]
   #
   #   # Use setters to not propagate changes:
   #   Base.setting = []
   #   Subclass.setting += [:foo]
-  #   Base.setting               #=> []
-  #   Subclass.setting           #=> [:foo]
+  #   Base.setting               # => []
+  #   Subclass.setting           # => [:foo]
   #
   # For convenience, a query method is defined as well:
   #
@@ -72,10 +72,21 @@ class Class
             remove_possible_method(:#{name})
             define_method(:#{name}) { val }
           end
+
+          if singleton_class?
+            class_eval do
+              remove_possible_method(:#{name})
+              def #{name}
+                defined?(@#{name}) ? @#{name} : singleton_class.#{name}
+              end
+            end
+          end
+          val
         end
 
+        remove_method :#{name} if method_defined?(:#{name})
         def #{name}
-          defined?(@#{name}) ? @#{name} : singleton_class.#{name}
+          defined?(@#{name}) ? @#{name} : self.class.#{name}
         end
 
         def #{name}?
@@ -86,4 +97,15 @@ class Class
       attr_writer name if instance_writer
     end
   end
+
+  private
+  def singleton_class?
+    # in case somebody is crazy enough to overwrite allocate
+    allocate = Class.instance_method(:allocate)
+    # object.class always points to a real (non-singleton) class
+    allocate.bind(self).call.class != self
+  rescue TypeError
+    # MRI/YARV/JRuby all disallow creating new instances of a singleton class
+    true
+  end
 end