diff options
| author | Dillon Welch <daw0328@gmail.com> | 2018-03-29 19:29:55 -0700 |
|---|---|---|
| committer | Dillon Welch <daw0328@gmail.com> | 2018-07-23 15:37:06 -0700 |
| commit | d108288c2f684233298f97f18ac00de0b016deaa (patch) | |
| tree | 0656fd6f20d662d854a3fc93e80dfbc0baec063d /activesupport/lib/active_support/callbacks.rb | |
| parent | a4398e412c042b297039cc216f6536b0c048bd9c (diff) | |
| download | rails-d108288c2f684233298f97f18ac00de0b016deaa.tar.gz rails-d108288c2f684233298f97f18ac00de0b016deaa.tar.bz2 rails-d108288c2f684233298f97f18ac00de0b016deaa.zip | |
Turn on performance based cops
Use attr_reader/attr_writer instead of methods
method is 12% slower
Use flat_map over map.flatten(1)
flatten is 66% slower
Use hash[]= instead of hash.merge! with single arguments
merge! is 166% slower
See https://github.com/rails/rails/pull/32337 for more conversation
Diffstat (limited to 'activesupport/lib/active_support/callbacks.rb')
| -rw-r--r-- | activesupport/lib/active_support/callbacks.rb | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/activesupport/lib/active_support/callbacks.rb b/activesupport/lib/active_support/callbacks.rb index a1b841ec3d..c266b432c0 100644 --- a/activesupport/lib/active_support/callbacks.rb +++ b/activesupport/lib/active_support/callbacks.rb @@ -497,9 +497,7 @@ module ActiveSupport arg.halted || !@user_conditions.all? { |c| c.call(arg.target, arg.value) } end - def nested - @nested - end + attr_reader :nested def final? !@call_template @@ -578,7 +576,7 @@ module ActiveSupport end protected - def chain; @chain; end + attr_reader :chain private |