diff options
author | Prathamesh Sonpatki <csonpatki@gmail.com> | 2016-07-17 19:35:39 +0530 |
---|---|---|
committer | Prathamesh Sonpatki <csonpatki@gmail.com> | 2016-07-17 19:35:39 +0530 |
commit | fd8ab8781488923c034200b83278d10dd8c90ba6 (patch) | |
tree | 7dcdb41067649f44cfdb7b6557c74d73bd43a7b2 /activesupport/lib/active_support.rb | |
parent | 75c51b034189aebf4fe2446ee82a85b28779f95b (diff) | |
download | rails-fd8ab8781488923c034200b83278d10dd8c90ba6.tar.gz rails-fd8ab8781488923c034200b83278d10dd8c90ba6.tar.bz2 rails-fd8ab8781488923c034200b83278d10dd8c90ba6.zip |
Refactor the existing session_store to use keyword args and raise early when set to activerecord session store
- Use keyword args as it is possible to use them now.
- The error message for activerecord-session_store gem was added in 1807384.
- But it was added for a code path which gets called when we try to
**access** the session store, not when we **set** it.
- So the test expecting the exception started failing because now the
session store is set via railtie again **after** setting it first with
:active_record_store in the test.
- As the error is not raised while setting the store to
:active_record_store, the store gets overwritten by railtie and when
we access it via `session_store` while building the default middleware
stack, the exception is not raised.
- This commit moves the code for raising the exception to the path where
we try to set the store.
Diffstat (limited to 'activesupport/lib/active_support.rb')
0 files changed, 0 insertions, 0 deletions