diff options
author | Sean Griffin <sean@thoughtbot.com> | 2015-07-18 08:42:29 -0400 |
---|---|---|
committer | Sean Griffin <sean@thoughtbot.com> | 2015-07-18 08:44:24 -0400 |
commit | 68af63618223c238468af1afb093eb4ccc706761 (patch) | |
tree | c265cfe4ae7322445bdfe3bc6aae197086477bd1 /activesupport/Rakefile | |
parent | c7449a2269c3d8b3f68b93401ab7a4fc524da918 (diff) | |
download | rails-68af63618223c238468af1afb093eb4ccc706761.tar.gz rails-68af63618223c238468af1afb093eb4ccc706761.tar.bz2 rails-68af63618223c238468af1afb093eb4ccc706761.zip |
Ensure that `ActionController::Parameters` can still be passed to AR
Since nested hashes are also instances of
`ActionController::Parameters`, and we're explicitly looking to work
with a hash for nested attributes, this caused breakage in several
points.
This is the minimum viable fix for the issue (and one that I'm not
terribly fond of). I can't think of a better place to handle this at the
moment. I'd prefer to use some sort of solution that doesn't special
case AC::Parameters, but we can't use something like `to_h` or `to_a`
since `Enumerable` adds both.
While I've added a trivial test case for verifying this fix in
isolation, we really need better integration coverage to prevent
regressions like this in the future. We don't actually have a lot of
great places for integration coverage at the moment, so I'm deferring it
for now.
Fixes #20922.
Diffstat (limited to 'activesupport/Rakefile')
0 files changed, 0 insertions, 0 deletions