diff options
| author | Dominik Sander <git@dsander.de> | 2018-04-17 22:03:02 +0200 |
|---|---|---|
| committer | Dominik Sander <git@dsander.de> | 2018-04-18 21:45:13 +0200 |
| commit | 7d25b651fa9011b040fab2f19fb315679519edb2 (patch) | |
| tree | f1ee16f98b5b76a58669e7dffbb3feba1520b893 /activesupport/CHANGELOG.md | |
| parent | 6378a386ddd1beb998ec9149a284d5fb13d491c7 (diff) | |
| download | rails-7d25b651fa9011b040fab2f19fb315679519edb2.tar.gz rails-7d25b651fa9011b040fab2f19fb315679519edb2.tar.bz2 rails-7d25b651fa9011b040fab2f19fb315679519edb2.zip | |
Fix exception in AS::Timezone.all when any tzinfo data is missing
Before this change missing timezone data for any of the time zones
defined in `ActiveSupport::Timezone::MAPPING` caused a `comparison of
NilClass with ActiveSupport::TimeZone failed` exception.
Attempting to get a timezone by passing a number/duration to `[]` or
calling `all` directly will try to sort sort the values of `zones_map`.
Those values are initialized by the return value of `create(zonename)`
which returns `nil` if `TZInfo` is unable to find the timezone
information.
In our case the exception was triggered by an outdated tzdata package
which did not include information for the "recently" added time zones.
Before 078421bacba178eac6a8e607b16f3f4511c5d72f `zones_map` only
returned the information that have been loaded into `@lazy_zone_map`
which ignored time zones for which the data could not be loaded, this
change restores the previous behaviour.
Diffstat (limited to 'activesupport/CHANGELOG.md')
| -rw-r--r-- | activesupport/CHANGELOG.md | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/activesupport/CHANGELOG.md b/activesupport/CHANGELOG.md index 82c985fae2..aa7e206bb2 100644 --- a/activesupport/CHANGELOG.md +++ b/activesupport/CHANGELOG.md @@ -1,3 +1,8 @@ +* Fix bug where `ActiveSupport::Timezone.all` would fail when tzinfo data for + any timezone defined in `ActiveSupport::MAPPING` is missing. + + *Dominik Sander* + * Fix bug where `ActiveSupport::Cache` will massively inflate the storage size when compression is enabled (which is true by default). This patch does not attempt to repair existing data: please manually flush the cache |