diff options
| author | Godfrey Chan <godfreykfc@gmail.com> | 2013-11-05 21:01:38 -0800 |
|---|---|---|
| committer | Godfrey Chan <godfreykfc@gmail.com> | 2013-11-06 17:16:11 -0800 |
| commit | 798881ecd4510b9e1e5e10529fc2d81b9deb961e (patch) | |
| tree | 5518edc1602caa1f36985f9ea8f9a725fa99fed2 /activesupport/CHANGELOG.md | |
| parent | 6da5ff45c6d69912fb96870f31aaf0c0590fa212 (diff) | |
| download | rails-798881ecd4510b9e1e5e10529fc2d81b9deb961e.tar.gz rails-798881ecd4510b9e1e5e10529fc2d81b9deb961e.tar.bz2 rails-798881ecd4510b9e1e5e10529fc2d81b9deb961e.zip | |
Do not expose internal state in the public encoder API (i.e. as_json)
See [1] for why this is not a good idea.
As part of this refactor, circular reference protection in as_json has
been removed and the corresponding error class has been deprecated.
As discussed with @jeremy, circular reference error is considered
programmer errors and protecting against it is out of scope for
the encoder.
This is again based on the excellent work by @sergiocampama in #11728.
[1]: https://github.com/intridea/multi_json/pull/138#issuecomment-24468223
Diffstat (limited to 'activesupport/CHANGELOG.md')
| -rw-r--r-- | activesupport/CHANGELOG.md | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/activesupport/CHANGELOG.md b/activesupport/CHANGELOG.md index 9e63a2bb17..3bb711c1ab 100644 --- a/activesupport/CHANGELOG.md +++ b/activesupport/CHANGELOG.md @@ -1,3 +1,8 @@ +* Removed circular reference protection in JSON encoder, deprecated + ActiveSupport::JSON::Encoding::CircularReferenceError. + + *Godfrey Chan*, *Sergio Campamá* + * Add `capitalize` option to Inflector.humanize, so strings can be humanized without being capitalized: 'employee_salary'.humanize # => "Employee salary" |