diff options
| author | Andrew White <andrew.white@unboxed.co> | 2019-03-18 16:51:33 +0000 |
|---|---|---|
| committer | Andrew White <andrew.white@unboxed.co> | 2019-03-18 17:02:34 +0000 |
| commit | 58ac3f212f0dca31d8dc3c35ba13c14581d8b5f3 (patch) | |
| tree | 33ca5cb87d3384e7a9ab986704211e31709676ba /activesupport/CHANGELOG.md | |
| parent | 014aa10fc0c2e1431235134c5f94c467e8c17cbd (diff) | |
| download | rails-58ac3f212f0dca31d8dc3c35ba13c14581d8b5f3.tar.gz rails-58ac3f212f0dca31d8dc3c35ba13c14581d8b5f3.tar.bz2 rails-58ac3f212f0dca31d8dc3c35ba13c14581d8b5f3.zip | |
Fix Time#advance to work with dates before 1001-03-07
In #10634 the behavior of Time#advance was changed to maintain a
proleptic gregorian calendar for dates before calendar reform. However
it didn't full address dates a long time before calendar reform and
they gradually drift away from the proleptic calendar the further you
go back in time. Fix this by always converting the date to gregorian
before calling advance which sets the reform date to -infinity.
Diffstat (limited to 'activesupport/CHANGELOG.md')
| -rw-r--r-- | activesupport/CHANGELOG.md | 14 |
1 files changed, 14 insertions, 0 deletions
diff --git a/activesupport/CHANGELOG.md b/activesupport/CHANGELOG.md index b2330f2c9d..63e2e44597 100644 --- a/activesupport/CHANGELOG.md +++ b/activesupport/CHANGELOG.md @@ -1,3 +1,17 @@ +* Fix `Time#advance` to work with dates before 1001-03-07 + + Before: + + Time.utc(1001, 3, 6).advance(years: -1) # => 1000-03-05 00:00:00 UTC + + After + + Time.utc(1001, 3, 6).advance(years: -1) # => 1000-03-06 00:00:00 UTC + + Note that this doesn't affect `DateTime#advance` as that doesn't use a proleptic calendar. + + *Andrew White* + * In Zeitwerk mode, engines are now managed by the `main` autoloader. Engines may reference application constants, if the application is reloaded and we do not reload engines, they won't use the reloaded application code. *Xavier Noria* |