diff options
| author | Ryuta Kamizono <kamipo@gmail.com> | 2019-04-16 16:43:08 +0900 |
|---|---|---|
| committer | Ryuta Kamizono <kamipo@gmail.com> | 2019-04-19 22:00:09 +0900 |
| commit | 8afdfdcfc92720162920aa6b59954ff4a1bfe831 (patch) | |
| tree | fb67efaee73e2b4d27c4b1d49c93adba5bb8593c /activestorage | |
| parent | 00310bf61aa0a3be1a4618e0dd3886dcfd05c799 (diff) | |
| download | rails-8afdfdcfc92720162920aa6b59954ff4a1bfe831.tar.gz rails-8afdfdcfc92720162920aa6b59954ff4a1bfe831.tar.bz2 rails-8afdfdcfc92720162920aa6b59954ff4a1bfe831.zip | |
Refactor `ActiveSupport::Deprecation.deprecate_methods` not to expose internal methods
In #33325, `deprecate_methods` is replaced from `prepend` to completely
emurated `alias_method_chain`, it exposed two internal methods
`xxx_with_deprecation` and `xxx_without_deprecation`.
After that, #34648 restored the `prepend` implementation, which doesn't
expose any internal methods, so we no longer be able to ensure to always
expose that internal methods.
As I said at https://github.com/rails/rails/pull/33325#issuecomment-409016725,
I think that internal methods exposed is not a specification but a
limitation when using `alias_method_chain`, there is no longer a reason
to follow that limitation.
Diffstat (limited to 'activestorage')
0 files changed, 0 insertions, 0 deletions