aboutsummaryrefslogtreecommitdiffstats
path: root/activestorage
diff options
context:
space:
mode:
authoryuuji.yaginuma <yuuji.yaginuma@gmail.com>2018-11-28 09:53:51 +0900
committeryuuji.yaginuma <yuuji.yaginuma@gmail.com>2018-11-28 10:01:03 +0900
commit7e7a60bd3fbfac9b02884f404bd31f3456f4022d (patch)
treec84881f63414555f7e57cfaf6d07a7dff4fc03b2 /activestorage
parent129788d6ec68e9e0c14e4048a63688a91b0ee45d (diff)
downloadrails-7e7a60bd3fbfac9b02884f404bd31f3456f4022d.tar.gz
rails-7e7a60bd3fbfac9b02884f404bd31f3456f4022d.tar.bz2
rails-7e7a60bd3fbfac9b02884f404bd31f3456f4022d.zip
Remove duplicated test
Since 06ab7b27ea1c1ab357085439abacdb464f6742bf, `GCSServiceTest#test_signed_URL_response_headers` is broken. https://travis-ci.org/rails/rails/jobs/460454477#L7084-L7087 This seems to be due to lack of `content_type` at upload. This is solved by specifying `conten_type`. However, since the same content is also tested with `test_upload_with_content_type`, it will be duplicated content, so I think that can remove `test_signed_URL_response_headers`.
Diffstat (limited to 'activestorage')
-rw-r--r--activestorage/test/service/gcs_service_test.rb14
1 files changed, 0 insertions, 14 deletions
diff --git a/activestorage/test/service/gcs_service_test.rb b/activestorage/test/service/gcs_service_test.rb
index 73337ef8e1..6d0695ba58 100644
--- a/activestorage/test/service/gcs_service_test.rb
+++ b/activestorage/test/service/gcs_service_test.rb
@@ -84,20 +84,6 @@ if SERVICE_CONFIGURATIONS[:gcs]
assert_match(/storage\.googleapis\.com\/.*response-content-disposition=inline.*test\.txt.*response-content-type=text%2Fplain/,
@service.url(@key, expires_in: 2.minutes, disposition: :inline, filename: ActiveStorage::Filename.new("test.txt"), content_type: "text/plain"))
end
-
- test "signed URL response headers" do
- begin
- key = SecureRandom.base58(24)
- data = "Something else entirely!"
- @service.upload(key, StringIO.new(data), checksum: Digest::MD5.base64digest(data))
-
- url = @service.url(key, expires_in: 2.minutes, disposition: :inline, filename: ActiveStorage::Filename.new("test.txt"), content_type: "text/plain")
- response = Net::HTTP.get_response(URI(url))
- assert_equal "text/plain", response.content_type
- ensure
- @service.delete key
- end
- end
end
else
puts "Skipping GCS Service tests because no GCS configuration was supplied"