diff options
| author | bogdanvlviv <bogdanvlviv@gmail.com> | 2018-07-23 03:33:25 +0300 |
|---|---|---|
| committer | bogdanvlviv <bogdanvlviv@gmail.com> | 2019-01-16 13:13:23 +0000 |
| commit | 2bad3f46cdd8decee7d2d9b804ac7c75b5a1cc5d (patch) | |
| tree | 364e5158279180a91c4a1fc9091ef7860cd7a687 /activestorage | |
| parent | d67863af390b45ed8dde551071a29b3d347bb8be (diff) | |
| download | rails-2bad3f46cdd8decee7d2d9b804ac7c75b5a1cc5d.tar.gz rails-2bad3f46cdd8decee7d2d9b804ac7c75b5a1cc5d.tar.bz2 rails-2bad3f46cdd8decee7d2d9b804ac7c75b5a1cc5d.zip | |
Add foreign key to active_storage_attachments for `blob_id` via new migration
We need this in order to be able to add this migration for users that
use ActiveStorage during update their apps from Rails 5.2 to Rails 6.0.
Related to #33405
`rake app:update` should update active_storage
`rake app:update` should execute `rake active_storage:update`
if it is used in the app that is being updated.
It will add new active_storage's migrations to users' apps during update Rails.
Context https://github.com/rails/rails/pull/33405#discussion_r204239399
Also, see a related discussion in the Campfire:
https://3.basecamp.com/3076981/buckets/24956/chats/12416418@1236713081
Diffstat (limited to 'activestorage')
| -rw-r--r-- | activestorage/db/update_migrate/20180723000244_add_foreign_key_constraint_to_active_storage_attachments_for_blob_id.rb | 7 | ||||
| -rw-r--r-- | activestorage/lib/tasks/activestorage.rake | 7 |
2 files changed, 14 insertions, 0 deletions
diff --git a/activestorage/db/update_migrate/20180723000244_add_foreign_key_constraint_to_active_storage_attachments_for_blob_id.rb b/activestorage/db/update_migrate/20180723000244_add_foreign_key_constraint_to_active_storage_attachments_for_blob_id.rb new file mode 100644 index 0000000000..6830203cd6 --- /dev/null +++ b/activestorage/db/update_migrate/20180723000244_add_foreign_key_constraint_to_active_storage_attachments_for_blob_id.rb @@ -0,0 +1,7 @@ +class AddForeignKeyConstraintToActiveStorageAttachmentsForBlobId < ActiveRecord::Migration[6.0] + def up + unless foreign_key_exists?(:active_storage_attachments, column: :blob_id) + add_foreign_key :active_storage_attachments, :active_storage_blobs, column: :blob_id + end + end +end diff --git a/activestorage/lib/tasks/activestorage.rake b/activestorage/lib/tasks/activestorage.rake index ac254d717f..6b0469636c 100644 --- a/activestorage/lib/tasks/activestorage.rake +++ b/activestorage/lib/tasks/activestorage.rake @@ -12,4 +12,11 @@ namespace :active_storage do Rake::Task["app:active_storage:install:migrations"].invoke end end + + # desc "Copy over the migrations needed to the application upgrading" + task update: :environment do + ENV["MIGRATIONS_PATH"] = "db/update_migrate" + + Rake::Task["active_storage:install"].invoke + end end |