Use assert_predicate and assert_not_predicate

6 files changed, 24 insertions, 24 deletions

diff --git a/activestorage/test/controllers/previews_controller_test.rb b/activestorage/test/controllers/previews_controller_test.rb
index 704a466160..b87be6c8b2 100644
--- a/activestorage/test/controllers/previews_controller_test.rb
+++ b/activestorage/test/controllers/previews_controller_test.rb
@@ -14,7 +14,7 @@ class ActiveStorage::PreviewsControllerTest < ActionDispatch::IntegrationTest
       signed_blob_id: @blob.signed_id,
       variation_key: ActiveStorage::Variation.encode(resize: "100x100"))
 
-    assert @blob.preview_image.attached?
+    assert_predicate @blob.preview_image, :attached?
     assert_redirected_to(/report\.png\?.*disposition=inline/)
 
     image = read_image(@blob.preview_image.variant(resize: "100x100"))
diff --git a/activestorage/test/models/attachments_test.rb b/activestorage/test/models/attachments_test.rb
index f0aa96b411..9ba2759893 100644
--- a/activestorage/test/models/attachments_test.rb
+++ b/activestorage/test/models/attachments_test.rb
@@ -65,14 +65,14 @@ class ActiveStorage::AttachmentsTest < ActiveSupport::TestCase
       end
     end
 
-    assert user.avatar.attached?
+    assert_predicate user.avatar, :attached?
     assert_equal "funky.jpg", user.avatar.filename.to_s
 
     assert_difference -> { ActiveStorage::Attachment.count }, +1 do
       user.save!
     end
 
-    assert user.reload.avatar.attached?
+    assert_predicate user.reload.avatar, :attached?
     assert_equal "funky.jpg", user.avatar.filename.to_s
   end
 
@@ -81,12 +81,12 @@ class ActiveStorage::AttachmentsTest < ActiveSupport::TestCase
       @user = User.new(name: "Jason", avatar: { io: StringIO.new("STUFF"), filename: "town.jpg", content_type: "image/jpg" })
     end
 
-    assert @user.new_record?
-    assert @user.avatar.attached?
+    assert_predicate @user, :new_record?
+    assert_predicate @user.avatar, :attached?
     assert_equal "town.jpg", @user.avatar.filename.to_s
 
     @user.save!
-    assert @user.reload.avatar.attached?
+    assert_predicate @user.reload.avatar, :attached?
     assert_equal "town.jpg", @user.avatar.filename.to_s
   end
 
@@ -106,12 +106,12 @@ class ActiveStorage::AttachmentsTest < ActiveSupport::TestCase
     @user.avatar.attach(blob)
 
     assert_equal "image/jpeg", @user.avatar.reload.content_type
-    assert @user.avatar.identified?
+    assert_predicate @user.avatar, :identified?
   end
 
   test "identify newly-attached blob only once" do
     blob = create_file_blob
-    assert blob.identified?
+    assert_predicate blob, :identified?
 
     # The blob's backing file is a PNG image. Fudge its content type so we can tell if it's identified when we attach it.
     blob.update! content_type: "application/octet-stream"
@@ -136,7 +136,7 @@ class ActiveStorage::AttachmentsTest < ActiveSupport::TestCase
       @user.avatar.attach blob
     end
 
-    assert blob.reload.analyzed?
+    assert_predicate blob.reload, :analyzed?
 
     @user.avatar.detach
 
@@ -161,7 +161,7 @@ class ActiveStorage::AttachmentsTest < ActiveSupport::TestCase
     avatar_key = @user.avatar.key
 
     @user.avatar.detach
-    assert_not @user.avatar.attached?
+    assert_not_predicate @user.avatar, :attached?
     assert ActiveStorage::Blob.exists?(avatar_blob_id)
     assert ActiveStorage::Blob.service.exist?(avatar_key)
   end
@@ -171,7 +171,7 @@ class ActiveStorage::AttachmentsTest < ActiveSupport::TestCase
     avatar_key = @user.avatar.key
 
     @user.avatar.purge
-    assert_not @user.avatar.attached?
+    assert_not_predicate @user.avatar, :attached?
     assert_not ActiveStorage::Blob.service.exist?(avatar_key)
   end
 
@@ -228,7 +228,7 @@ class ActiveStorage::AttachmentsTest < ActiveSupport::TestCase
       end
     end
 
-    assert user.highlights.attached?
+    assert_predicate user.highlights, :attached?
     assert_equal "town.jpg", user.highlights.first.filename.to_s
     assert_equal "country.jpg", user.highlights.second.filename.to_s
 
@@ -236,7 +236,7 @@ class ActiveStorage::AttachmentsTest < ActiveSupport::TestCase
       user.save!
     end
 
-    assert user.reload.highlights.attached?
+    assert_predicate user.reload.highlights, :attached?
     assert_equal "town.jpg", user.highlights.first.filename.to_s
     assert_equal "country.jpg", user.highlights.second.filename.to_s
   end
@@ -248,13 +248,13 @@ class ActiveStorage::AttachmentsTest < ActiveSupport::TestCase
         { io: StringIO.new("IT"), filename: "country.jpg", content_type: "image/jpg" }])
     end
 
-    assert @user.new_record?
-    assert @user.highlights.attached?
+    assert_predicate @user, :new_record?
+    assert_predicate @user.highlights, :attached?
     assert_equal "town.jpg", @user.highlights.first.filename.to_s
     assert_equal "country.jpg", @user.highlights.second.filename.to_s
 
     @user.save!
-    assert @user.reload.highlights.attached?
+    assert_predicate @user.reload.highlights, :attached?
     assert_equal "town.jpg", @user.highlights.first.filename.to_s
     assert_equal "country.jpg", @user.highlights.second.filename.to_s
   end
@@ -334,7 +334,7 @@ class ActiveStorage::AttachmentsTest < ActiveSupport::TestCase
     highlight_keys = @user.highlights.collect(&:key)
 
     @user.highlights.detach
-    assert_not @user.highlights.attached?
+    assert_not_predicate @user.highlights, :attached?
 
     assert ActiveStorage::Blob.exists?(highlight_blob_ids.first)
     assert ActiveStorage::Blob.exists?(highlight_blob_ids.second)
@@ -348,7 +348,7 @@ class ActiveStorage::AttachmentsTest < ActiveSupport::TestCase
     highlight_keys = @user.highlights.collect(&:key)
 
     @user.highlights.purge
-    assert_not @user.highlights.attached?
+    assert_not_predicate @user.highlights, :attached?
     assert_not ActiveStorage::Blob.service.exist?(highlight_keys.first)
     assert_not ActiveStorage::Blob.service.exist?(highlight_keys.second)
   end
diff --git a/activestorage/test/models/blob_test.rb b/activestorage/test/models/blob_test.rb
index b5daee2b57..44b60e5cbb 100644
--- a/activestorage/test/models/blob_test.rb
+++ b/activestorage/test/models/blob_test.rb
@@ -25,8 +25,8 @@ class ActiveStorage::BlobTest < ActiveSupport::TestCase
 
   test "text?" do
     blob = create_blob data: "Hello world!"
-    assert blob.text?
-    assert_not blob.audio?
+    assert_predicate blob, :text?
+    assert_not_predicate blob, :audio?
   end
 
   test "download yields chunks" do
diff --git a/activestorage/test/models/preview_test.rb b/activestorage/test/models/preview_test.rb
index b0c6d2c45b..55fdc228c8 100644
--- a/activestorage/test/models/preview_test.rb
+++ b/activestorage/test/models/preview_test.rb
@@ -8,7 +8,7 @@ class ActiveStorage::PreviewTest < ActiveSupport::TestCase
     blob = create_file_blob(filename: "report.pdf", content_type: "application/pdf")
     preview = blob.preview(resize: "640x280").processed
 
-    assert preview.image.attached?
+    assert_predicate preview.image, :attached?
     assert_equal "report.png", preview.image.filename.to_s
     assert_equal "image/png", preview.image.content_type
 
@@ -21,7 +21,7 @@ class ActiveStorage::PreviewTest < ActiveSupport::TestCase
     blob = create_file_blob(filename: "video.mp4", content_type: "video/mp4")
     preview = blob.preview(resize: "640x280").processed
 
-    assert preview.image.attached?
+    assert_predicate preview.image, :attached?
     assert_equal "video.png", preview.image.filename.to_s
     assert_equal "image/png", preview.image.content_type
 
diff --git a/activestorage/test/service/mirror_service_test.rb b/activestorage/test/service/mirror_service_test.rb
index 08efb095bc..40476d636e 100644
--- a/activestorage/test/service/mirror_service_test.rb
+++ b/activestorage/test/service/mirror_service_test.rb
@@ -60,7 +60,7 @@ class ActiveStorage::Service::MirrorServiceTest < ActiveSupport::TestCase
       SecureRandom.base58(24).tap do |key|
         io = StringIO.new(data).tap(&:read)
         @service.upload key, io, checksum: Digest::MD5.base64digest(data)
-        assert io.eof?
+        assert_predicate io, :eof?
       end
     end
 end
diff --git a/activestorage/test/template/image_tag_test.rb b/activestorage/test/template/image_tag_test.rb
index 80f183e0e3..f0b166c225 100644
--- a/activestorage/test/template/image_tag_test.rb
+++ b/activestorage/test/template/image_tag_test.rb
@@ -33,7 +33,7 @@ class ActiveStorage::ImageTagTest < ActionView::TestCase
   test "error when attachment's empty" do
     @user = User.create!(name: "DHH")
 
-    assert_not @user.avatar.attached?
+    assert_not_predicate @user.avatar, :attached?
     assert_raises(ArgumentError) { image_tag(@user.avatar) }
   end