diff options
author | Cameron Cundiff <github@ckundo.com> | 2017-08-16 14:34:02 -0400 |
---|---|---|
committer | Cameron Cundiff <github@ckundo.com> | 2017-08-17 16:13:15 -0400 |
commit | 9a74c7b99bf0ac901f86bb38372a68e157cf9c73 (patch) | |
tree | 35baa306f1853c73aeb1088fa1fbfda5ea8e0d13 /activestorage/test/template/image_tag_test.rb | |
parent | d2f493c7ed7a95f48730aecdcfbcc7bbee30921b (diff) | |
download | rails-9a74c7b99bf0ac901f86bb38372a68e157cf9c73.tar.gz rails-9a74c7b99bf0ac901f86bb38372a68e157cf9c73.tar.bz2 rails-9a74c7b99bf0ac901f86bb38372a68e157cf9c73.zip |
Do not generate default alt text in image tags
- Auto-generating content from the filename of an image is not suitable
alternative text; alt text that isn't fully considered can be
distracting and fatiguing for screen readers users (blind, low vision,
dyslexic people).
- Setting a filename fallback short circuits screen reader default
behavior and configuration for blank descriptions.
- Setting poor defaults also creates false negatives for accessibility
linting and testing software, that makes it harder to improve
application accessibility.
***
- After this change, if authors leave images without alt text, screen
readers will fallback to default behavior for missing alt text.
- Also with this change, Automated linting and testing tools will
correctly generate warnings.
[Fixes #30096]
Diffstat (limited to 'activestorage/test/template/image_tag_test.rb')
-rw-r--r-- | activestorage/test/template/image_tag_test.rb | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/activestorage/test/template/image_tag_test.rb b/activestorage/test/template/image_tag_test.rb index 46dd97b3e9..dedc58452e 100644 --- a/activestorage/test/template/image_tag_test.rb +++ b/activestorage/test/template/image_tag_test.rb @@ -11,17 +11,17 @@ class ActiveStorage::ImageTagTest < ActionView::TestCase end test "blob" do - assert_dom_equal %(<img alt="Racecar" src="#{polymorphic_url @blob}" />), image_tag(@blob) + assert_dom_equal %(<img src="#{polymorphic_url @blob}" />), image_tag(@blob) end test "variant" do variant = @blob.variant(resize: "100x100") - assert_dom_equal %(<img alt="Racecar" src="#{polymorphic_url variant}" />), image_tag(variant) + assert_dom_equal %(<img src="#{polymorphic_url variant}" />), image_tag(variant) end test "attachment" do attachment = ActiveStorage::Attachment.new(blob: @blob) - assert_dom_equal %(<img alt="Racecar" src="#{polymorphic_url attachment}" />), image_tag(attachment) + assert_dom_equal %(<img src="#{polymorphic_url attachment}" />), image_tag(attachment) end test "error when attachment's empty" do |